mayeco/GoogleBundle

View on GitHub

Showing 7 of 7 total issues

Method getConfigTreeBuilder has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('mayeco_google');

Severity: Major
Found in DependencyInjection/Configuration.php - About 2 hrs to fix

    Method refreshAccess has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function refreshAccess($id, $refreshToken, $force = false)
        {
            $fromcache = true;
            if($force) {
                $this->cache->delete($id . '_token');
    Severity: Major
    Found in Services/GoogleUtils.php - About 2 hrs to fix

      Method authenticateAccess has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function authenticateAccess($code)
          {
      
              try {
      
      
      Severity: Minor
      Found in Services/GoogleUtils.php - About 1 hr to fix

        Function refreshAccess has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function refreshAccess($id, $refreshToken, $force = false)
            {
                $fromcache = true;
                if($force) {
                    $this->cache->delete($id . '_token');
        Severity: Minor
        Found in Services/GoogleUtils.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method downloadReport has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function downloadReport($clientId, \ReportDefinition $reportDefinition, $format, $path = null, array $options = null)
        Severity: Minor
        Found in Services/GoogleUtils.php - About 35 mins to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  AdWordsUser $adwordsuser,
                  Google_Client $googleclient,
                  Cache $cache,
                  UrlGeneratorInterface $router,
                  $app_redirect_route
          Severity: Minor
          Found in Services/GoogleUtils.php - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                    return array(
                        "accessType" => $tokeninfo->accessType,
                        "audience" => $tokeninfo->audience,
                        "email" => $tokeninfo->email,
                        "expiresIn" => $tokeninfo->expiresIn,
            Severity: Major
            Found in Services/GoogleUtils.php - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language