Sign upLogin

mbeauv/urbanoe-communications

View on GitHub
Star
src/media_gallery/reducers/__tests__/image_galleries_reducer.js

Summary

Maintainability
D
2 days
Test Coverage

File image_galleries_reducer.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow

import { Map } from 'immutable';
import type { ImageGallery } from '../../models/ImageGallery';
import {
Severity: Minor
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      it('processes IMAGE_GALLERY_LIST_DELETE_RESPONSE_ERROR', () => {
        const expectedState = {
          loading: false,
          error: null,
          galleries: Map({
Severity: Major
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js and 1 other location - About 3 hrs to fix
src/media_gallery/reducers/__tests__/image_galleries_reducer.js on lines 272..290

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      it('processes IMAGE_GALLERY_UPDATE_RESPONSE_ERROR', () => {
        const expectedState = {
          loading: false,
          error: null,
          galleries: Map({
Severity: Major
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js and 1 other location - About 3 hrs to fix
src/media_gallery/reducers/__tests__/image_galleries_reducer.js on lines 221..238

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      it('processes IMAGE_GALLERY_CREATE_RESPONSE_ERROR', () => {
        const startState = { loading: true, error: null, galleries: Map() };
        const expectedState = { loading: false, error: ERROR, galleries: Map() };

        expect(imageGalleriesReducer(startState, {
Severity: Major
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js and 1 other location - About 3 hrs to fix
src/media_gallery/reducers/__tests__/image_galleries_reducer.js on lines 106..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      it('processes IMAGE_GALLERY_LIST_RESPONSE_ERROR correctly', () => {
        const startState = { loading: true, error: null, galleries: Map() };
        const expectedState = { loading: false, error: ERROR, galleries: Map() };

        expect(imageGalleriesReducer(
Severity: Major
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js and 1 other location - About 3 hrs to fix
src/media_gallery/reducers/__tests__/image_galleries_reducer.js on lines 174..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      it('processes IMAGE_GALLERY_LIST_DELETE_REQUEST', () => {
        const expectedState = {
          loading: false,
          error: null,
          galleries: Map({
Severity: Major
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js and 1 other location - About 2 hrs to fix
src/media_gallery/reducers/__tests__/image_galleries_reducer.js on lines 253..270

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      it('processes IMAGE_GALLERY_UPDATE_REQUEST', () => {
        const expectedState = {
          loading: false,
          error: null,
          galleries: Map({
Severity: Major
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js and 1 other location - About 2 hrs to fix
src/media_gallery/reducers/__tests__/image_galleries_reducer.js on lines 202..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      state = {
        loading: false,
        error: null,
        galleries: Map({
          gallery_6: {
Severity: Major
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js and 2 other locations - About 1 hr to fix
src/media_gallery/reducers/__tests__/image_galleries_reducer.js on lines 119..133
src/media_gallery/reducers/__tests__/image_infos_reducer.js on lines 42..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        const expectedState = {
          loading: false,
          error: null,
          galleries: Map({
            gallery_5: {
Severity: Major
Found in src/media_gallery/reducers/__tests__/image_galleries_reducer.js and 2 other locations - About 1 hr to fix
src/media_gallery/reducers/__tests__/image_galleries_reducer.js on lines 38..53
src/media_gallery/reducers/__tests__/image_infos_reducer.js on lines 42..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status