mbland/slack-github-issues

View on GitHub

Showing 3 of 7 total issues

Function sendRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function sendRequest(client, method, params, resolve, reject) {
Severity: Minor
Found in lib/slack-client.js - About 35 mins to fix

    Function ReactionIssueFiler has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function ReactionIssueFiler(config, slackClient, githubClient, messageLock,
      logger) {
    Severity: Minor
    Found in lib/reaction-issue-filer.js - About 35 mins to fix

      Function reactionIssueFiler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        reactionIssueFiler: function(configParams, slackDataStore, messageLock,
            logger) {
          var filerConfig
      
          if (!configParams.path && !configParams.data) {
      Severity: Minor
      Found in index.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language