Sign upLogin

mbland/url-pointers

View on GitHub
Star
public/app.js

Summary

Maintainability
F
3 days
Test Coverage

File app.js has 821 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-env browser */
'use strict';

(function(f) { f(window, document) })(function(window,  document) {
  var cl = window.cl = {}
Severity: Major
Found in public/app.js - About 1 day to fix

    Function createLinksTable has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      cl.createLinksTable = function(links, linksView, options) {
    var linkTable = cl.getTemplate('links'),
        linkEntry = cl.getTemplate('link'),
        sortKey,
        order
    Severity: Minor
    Found in public/app.js - About 1 hr to fix

      Function Dialog has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        cl.Dialog = function(templateName, data, startOperation, resultElement) {
    var dialog = this,
        errPrefix = 'The "' + templateName + '" dialog box template '

    this.name = templateName
      Severity: Minor
      Found in public/app.js - About 1 hr to fix

        Function linksView has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          cl.linksView = function() {
    var element = cl.getTemplate('links-view'),
        linksView = new cl.View(element, function() {
          cl.focusFirstElement(element, 'a')
        })
        Severity: Minor
        Found in public/app.js - About 1 hr to fix

          Function xhr has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            cl.xhr = function(method, url, body) {
    return new Promise(function(resolve, reject) {
      var r = new XMLHttpRequest()

      r.open(method, url, true)
          Severity: Minor
          Found in public/app.js - About 1 hr to fix

            Function makeApiCall has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              cl.Backend.prototype.makeApiCall = function(method, endpoint, linkInfo,
    params, okMsg, errPrefix) {
            Severity: Minor
            Found in public/app.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                cl.Dropdown.prototype.previous = function(keyEvent, item) {
    if (cl.keyEvents.isSelectPreviousItem(keyEvent)) {
      if (item === this.items.firstChild) {
        this.items.lastChild.focus()
      } else {
              Severity: Major
              Found in public/app.js and 1 other location - About 3 hrs to fix
              public/app.js on lines 385..394

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 103.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                cl.Dropdown.prototype.next = function(keyEvent, item) {
    if (cl.keyEvents.isSelectNextItem(keyEvent)) {
      if (item === this.items.lastChild) {
        this.items.firstChild.focus()
      } else {
              Severity: Major
              Found in public/app.js and 1 other location - About 3 hrs to fix
              public/app.js on lines 396..405

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 103.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  isSelectNextItem: function(keyEvent) {
      return cl.keyEvents.NEXT_ITEM_KEYS.indexOf(keyEvent.code) !== -1 ||
        cl.keyEvents.isEnterNextElement(keyEvent)
    },
              Severity: Major
              Found in public/app.js and 1 other location - About 1 hr to fix
              public/app.js on lines 435..438

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  isSelectPreviousItem: function(keyEvent) {
      return cl.keyEvents.PREV_ITEM_KEYS.indexOf(keyEvent.code) !== -1 ||
        cl.keyEvents.isEnterPreviousElement(keyEvent)
    }
              Severity: Major
              Found in public/app.js and 1 other location - About 1 hr to fix
              public/app.js on lines 424..427

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status