mbroadst/amqp10-rpc

View on GitHub
lib/rpc-server.js

Summary

Maintainability
D
1 day
Test Coverage

Function _processMessage has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

RpcServer.prototype._processMessage = function(receiver, message) {
  if (!u.assertProperties(message, this._logger, ['body']))
    return receiver.modify(message, { undeliverableHere: true });

  var self = this;
Severity: Major
Found in lib/rpc-server.js - About 2 hrs to fix

    Function bind has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    RpcServer.prototype.bind = function(methodNameOrDef, method) {
      var methodName, methodFunc, methodValidations, interceptor;
      if (typeof methodNameOrDef === 'function') {
        if (methodNameOrDef.name === undefined ||
            methodNameOrDef.name === null || methodNameOrDef.name === '')
    Severity: Minor
    Found in lib/rpc-server.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function bind has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    RpcServer.prototype.bind = function(methodNameOrDef, method) {
      var methodName, methodFunc, methodValidations, interceptor;
      if (typeof methodNameOrDef === 'function') {
        if (methodNameOrDef.name === undefined ||
            methodNameOrDef.name === null || methodNameOrDef.name === '')
    Severity: Minor
    Found in lib/rpc-server.js - About 1 hr to fix

      Function _processMessage has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      RpcServer.prototype._processMessage = function(receiver, message) {
        if (!u.assertProperties(message, this._logger, ['body']))
          return receiver.modify(message, { undeliverableHere: true });
      
        var self = this;
      Severity: Minor
      Found in lib/rpc-server.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _processRequest has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      RpcServer.prototype._processRequest = function(replyTo, correlationId, request) {
        if (!request.hasOwnProperty('method')) {
          throw new errors.InvalidRequestError('Missing required property: method', {
            source: { replyTo: replyTo, request: request }
          });
      Severity: Minor
      Found in lib/rpc-server.js - About 1 hr to fix

        Function _respond has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        RpcServer.prototype._respond = function(replyTo, correlationId, response) {
          if (response === null || response === undefined) return;
          if (response.hasOwnProperty('error') &&
              response.error.code === ErrorCode.MethodNotFound && !!this._ignoreUnknownMethods) {
            return;
        Severity: Minor
        Found in lib/rpc-server.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _processRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        RpcServer.prototype._processRequest = function(replyTo, correlationId, request) {
          if (!request.hasOwnProperty('method')) {
            throw new errors.InvalidRequestError('Missing required property: method', {
              source: { replyTo: replyTo, request: request }
            });
        Severity: Minor
        Found in lib/rpc-server.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

          return this._client.createSender(replyTo)
            .then(function(sender) { return sender.send(response, { properties: properties }); });
        Severity: Major
        Found in lib/rpc-server.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return response
              .then(function(response) { return formatResponse(response); })
              .error(function(err) {
                receiver.accept(message);
                return formatError(err);
          Severity: Major
          Found in lib/rpc-server.js - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status