mbroadst/thinkagain

View on GitHub
lib/util.js

Summary

Maintainability
C
1 day
Test Coverage

Function injectTermSupport has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

util.injectTermSupport = schema => {
  if (schema.type === 'object') {
    if (!schema.hasOwnProperty('properties')) {
      return schema;
    }
Severity: Minor
Found in lib/util.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function hook has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function hook(options) {
  let preHooks = options.preHooks;
  if (Array.isArray(preHooks) === false) {
    preHooks = [];
  }
Severity: Minor
Found in lib/util.js - About 1 hr to fix

    Function _asyncHook has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function _asyncHook(args) {
      // One of the hook, or the function is asynchronous, so we will
      // always return a promise
      // We only need to keep track of the result return/resolved for fn
    
    
    Severity: Minor
    Found in lib/util.js - About 1 hr to fix

      Function injectTermSupport has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      util.injectTermSupport = schema => {
        if (schema.type === 'object') {
          if (!schema.hasOwnProperty('properties')) {
            return schema;
          }
      Severity: Minor
      Found in lib/util.js - About 1 hr to fix

        Function recurse has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function recurse(key, joins, modelTo, all, done) {
        Severity: Minor
        Found in lib/util.js - About 35 mins to fix

          Function executeHooks has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function executeHooks(hookIndex, hooks, doc, reject, next) {
          Severity: Minor
          Found in lib/util.js - About 35 mins to fix

            Function loopKeys has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function loopKeys(obj, fn) {
              if (isPlainObject(obj)) {
                let keys = Object.keys(obj);
                let result;
                for (let i = 0, ii = keys.length; i < ii; ++i) {
            Severity: Minor
            Found in lib/util.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function deepCopy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function deepCopy(value) {
              let result;
              if (value instanceof Buffer) {
                // isPlainObject(buffer) returns true.
                return new Buffer(value);
            Severity: Minor
            Found in lib/util.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              for (let j = 0, jj = postHooks.length; j < jj; ++j) {
                postHooks[j].call(doc);
              }
            Severity: Minor
            Found in lib/util.js and 1 other location - About 35 mins to fix
            lib/util.js on lines 124..126

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              for (let i = 0, ii = preHooks.length; i < ii; ++i) {
                preHooks[i].call(doc);
              }
            Severity: Minor
            Found in lib/util.js and 1 other location - About 35 mins to fix
            lib/util.js on lines 129..131

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status