Sign upLogin

mckramer/earth_tools

View on GitHub
Star

Showing 4 of 4 total issues

Method search has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def search(*options)
        begin
          Timeout::timeout(EarthTools::Configuration.timeout) do
            uri = query(options)
            if cache && results = cache[uri]
Severity: Minor
Found in lib/earth_tools/lookup/base.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method valid_full_input? has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def valid_full_input?(latitude, longitude, day, month, timezone, dst)
Severity: Minor
Found in lib/earth_tools.rb - About 45 mins to fix

    Method sunrise_sunset has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def sunrise_sunset(latitude, longitude, month, day, timezone = 99, dst = false)
    Severity: Minor
    Found in lib/earth_tools.rb - About 45 mins to fix

      Method expire has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def expire(url)
      if url == :all
        urls.each{ |u| expire(u) }
      else
        @store.send(@store.respond_to?(:del) ? :del : :delete, key_for(url))
      Severity: Minor
      Found in lib/earth_tools/cache.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language