Showing 6 of 9 total issues
Function validateManifest
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
Open
module.exports = function validateManifest (manifest) {
return getClientVersion()
.then(clientVersion => {
if (!manifest.name || !/^[a-z]([\w-]*[a-z])?$/i.test(manifest.name)) {
throw new Error('Invalid package name!')
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function flattenFileList
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
module.exports = function flattenFileList (hash, folderPath, zipPath) {
return new Promise((resolve, reject) => {
if (!folderPath) {
throw new Error('Package directory not specified!')
}
- Create a ticketCreate a ticket
Function parsePackageString
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function parsePackageString (str) {
if (typeof str !== 'string' || (str.match(/:/g) || []).length > 1) {
return {
type: 'unknown'
}
- Create a ticketCreate a ticket
Function parsePackageString
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
function parsePackageString (str) {
if (typeof str !== 'string' || (str.match(/:/g) || []).length > 1) {
return {
type: 'unknown'
}
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
Open
return {
name: str.substring('folder:'.length),
type: 'folder'
}
- Create a ticketCreate a ticket
Avoid too many return
statements within this function. Open
Open
return {
name: str,
type: 'folder'
}
- Create a ticketCreate a ticket