Sign upLogin

media3-0/apki.org

View on GitHub
Star

Showing 25 of 122 total issues

Avoid too many return statements within this function.
Open

    return false
Severity: Major
Found in public/javascripts/bootstrap.js - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return expression == output
    Severity: Major
    Found in app/lib/course/course_checker.rb - About 30 mins to fix

      Method grant_achievement has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.grant_achievement(json_response, user_course, id, id_type, lesson_achievement = false)
      query = Course::Achievement.where(id_type => id)
      json_response_key = 'achievement_granted'
      json_response_key = 'lesson_achievement_granted' if lesson_achievement
      if query.exists?
      Severity: Minor
      Found in app/lib/course/course_checker.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method redirection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def redirection(message, status = :unauthorized, spec = nil)
    redirect_path = root_path
    redirect_path = request.referrer if request.referrer

    if json_request?
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def index
      course_courses_data = Course::CourseDatum.get_list(current_user)
      courses_hashes = []
      course_courses_data.each do |course|
        courses_hashes << object_to_json(course)
      Severity: Minor
      Found in app/controllers/course/course_data_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language