Sign upLogin

medialize/ally.js

View on GitHub
Star
test/unit/is.valid-tabindex.test.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    bdd.describe('for document structure', function() {
      bdd.it('should return false for document', function() {
        expect(isValidTabindex(document)).to.equal(false);
      });
Severity: Major
Found in test/unit/is.valid-tabindex.test.js and 5 other locations - About 7 hrs to fix
test/unit/is.focus-relevant.test.js on lines 44..60
test/unit/is.focusable.test.js on lines 44..60
test/unit/is.only-tabbable.test.js on lines 50..66
test/unit/is.shadowed.test.js on lines 27..43
test/unit/is.tabbable.test.js on lines 52..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 189.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      bdd.it('should return true for tabindex="0 " (trailing space)', function() {
        var element = document.getElementById('tabindex-0-space');
        expect(element.tabIndex).to.equal(0, 'tabIndex property');
        expect(isValidTabindex(element)).to.equal(true, 'isValidTabindex()');
      });
Severity: Major
Found in test/unit/is.valid-tabindex.test.js and 2 other locations - About 2 hrs to fix
test/unit/is.valid-tabindex.test.js on lines 71..75
test/unit/is.valid-tabindex.test.js on lines 77..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      bdd.it('should return true for tabindex="1"', function() {
        var element = document.getElementById('tabindex-1');
        expect(element.tabIndex).to.equal(1, 'tabIndex property');
        expect(isValidTabindex(element)).to.equal(true, 'isValidTabindex()');
      });
Severity: Major
Found in test/unit/is.valid-tabindex.test.js and 2 other locations - About 2 hrs to fix
test/unit/is.valid-tabindex.test.js on lines 71..75
test/unit/is.valid-tabindex.test.js on lines 83..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      bdd.it('should return true for tabindex="0"', function() {
        var element = document.getElementById('tabindex-0');
        expect(element.tabIndex).to.equal(0, 'tabIndex property');
        expect(isValidTabindex(element)).to.equal(true, 'isValidTabindex()');
      });
Severity: Major
Found in test/unit/is.valid-tabindex.test.js and 2 other locations - About 2 hrs to fix
test/unit/is.valid-tabindex.test.js on lines 77..81
test/unit/is.valid-tabindex.test.js on lines 83..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      bdd.it('should return {browser-specific} for tabindex="" (empty)', function() {
        var element = document.getElementById('tabindex-empty');
        // .tabIndex IE: 0, rest: -1
        expect(isValidTabindex(element)).to.equal(supports.focusInvalidTabindex);
      });
Severity: Major
Found in test/unit/is.valid-tabindex.test.js and 1 other location - About 1 hr to fix
test/unit/is.valid-tabindex.test.js on lines 95..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      bdd.it('should return {browser-specific} for tabindex="bad"', function() {
        var element = document.getElementById('tabindex-bad');
        // .tabIndex IE: 0, rest: -1
        expect(isValidTabindex(element)).to.equal(supports.focusInvalidTabindex);
      });
Severity: Major
Found in test/unit/is.valid-tabindex.test.js and 1 other location - About 1 hr to fix
test/unit/is.valid-tabindex.test.js on lines 101..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    bdd.it('should handle invalid input', function() {
      expect(function() {
        isValidTabindex(null);
      }).to.throw(TypeError, 'is/valid-tabindex requires valid options.context');
    });
Severity: Major
Found in test/unit/is.valid-tabindex.test.js and 8 other locations - About 40 mins to fix
test/unit/element.blur.test.js on lines 22..26
test/unit/element.disabled.test.js on lines 111..115
test/unit/element.focus.test.js on lines 24..28
test/unit/is.active-element.test.js on lines 22..26
test/unit/is.disabled.test.js on lines 38..42
test/unit/is.native-disabled-supported.test.js on lines 34..38
test/unit/is.shadowed.test.js on lines 21..25
test/unit/is.valid-area.test.js on lines 60..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Unexpected '!' in 'intern!bdd'. Do not use import syntax to configure webpack loaders.
Open

  var bdd = require('intern!bdd');
Severity: Minor
Found in test/unit/is.valid-tabindex.test.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Unexpected '!' in 'intern/chai!expect'. Do not use import syntax to configure webpack loaders.
Open

  var expect = require('intern/chai!expect');
Severity: Minor
Found in test/unit/is.valid-tabindex.test.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status