meili-epfl/Meili

View on GitHub

Showing 6 of 52 total issues

Class PhotoEditActivity has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

/**
 * An activity which is launched after a photo has been taken by the camera activity. It lets the user edit the photo by drawing, adding filters, etc.
 */
class PhotoEditActivity : AppCompatActivity() {
    private lateinit var binding: ActivityPhotoEditBinding
Severity: Minor
Found in app/src/main/java/com/github/epfl/meili/photo/PhotoEditActivity.kt - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (other != null && other::class.java == PointOfInterest::class.java) {
                val otherPoi = other as PointOfInterest
                return otherPoi.latitude == latitude && otherPoi.longitude == longitude && otherPoi.name == name
                        && otherPoi.uid == uid && otherPoi.icon == icon
            }
    Severity: Major
    Found in app/src/main/java/com/github/epfl/meili/models/PointOfInterest.kt - About 40 mins to fix

      Method onActivityResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              activity: Activity,
              requestCode: Int,
              result: Int,
              data: Intent?,
              onComplete: () -> Unit
      Severity: Minor
      Found in app/src/main/java/com/github/epfl/meili/auth/Auth.kt - About 35 mins to fix

        Method onActivityResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                    activity: Activity,
                    requestCode: Int,
                    result: Int,
                    data: Intent?,
                    onComplete: () -> Unit

          Method onActivityResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  activity: Activity,
                  requestCode: Int,
                  result: Int,
                  data: Intent?,
                  onComplete: () -> Unit

            Method onActivityResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    activity: Activity,
                    requestCode: Int,
                    result: Int,
                    data: Intent?,
                    onComplete: () -> Unit
            Severity: Minor
            Found in app/src/main/java/com/github/epfl/meili/auth/AuthenticationService.kt - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language