Sign upLogin

menglifang/dcm4chee

View on GitHub
Star

Showing 2 of 11 total issues

Method schedule_move has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def schedule_move(retrieve_aet,
                        dest_aet,
                        priority,
                        pid,
                        study_iuids,
Severity: Major
Found in lib/dcm4chee/services/move_scu_service.rb - About 1 hr to fix

    Method dcm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def dcm
      tsuid = defined?(dicom_file) ? dicom_file.transfer_syntax_uid : ::DICOM::EXPLICIT_LITTLE_ENDIAN

      return nil unless dicom_attributes
    Severity: Minor
    Found in lib/dcm4chee/models/has_dicom_object.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language