Sign upLogin

menglifang/task-manager

View on GitHub
Star
app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js

Summary

Maintainability
D
1 day
Test Coverage

Function initComponent has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    initComponent: function() 
    {
        var    me = this;
        
        me.tree = Ext.create('Ext.tree.Panel',
Severity: Minor
Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function initComponent has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    initComponent: function() 
    {
        var    me = this;
        
        me.tree = Ext.create('Ext.tree.Panel',
Severity: Major
Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js - About 2 hrs to fix

    Function setValue has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        setValue: function(valueInit)
    {
        if(typeof valueInit == 'undefined') return;
        
        var    me = this,
    Severity: Minor
    Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js - About 1 hr to fix

      Function itemclick has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      itemclick: function(view, record, item, index, e, eOpts)
                {
                    var values = [];
                    
                    var node = me.tree.getRootNode().findChild('id', record.get(me.valueField), true);
      Severity: Minor
      Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js - About 1 hr to fix

        Function itemclick has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                        itemclick: function(view, record, item, index, e, eOpts)
        Severity: Minor
        Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js - About 45 mins to fix

          Function setValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              setValue: function(valueInit)
    {
        if(typeof valueInit == 'undefined') return;
        
        var    me = this,
          Severity: Minor
          Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              Ext.each(me.records, function(record)
                    {
                        values.push(record.get(me.valueField));
                    });
          Severity: Minor
          Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js and 1 other location - About 30 mins to fix
          app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js on lines 165..168

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  Ext.each(me.records, function(value)
        {
            ids.push(value.get(me.valueField));
        });
          Severity: Minor
          Found in app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js and 1 other location - About 30 mins to fix
          app/assets/javascripts/task-manager/extjs/lib/ux/TreeCombo.js on lines 251..254

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status