Sign upLogin

metaminded/tabulatr2

View on GitHub
Star
app/assets/javascripts/tabulatr/_tabulatr.js

Summary

Maintainability
C
1 day
Test Coverage

File _tabulatr.js has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

function Tabulatr(id){
  this.id = id;
  this.name = '';
  this.moreResults = true;
  this.currentData = null;
Severity: Minor
Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 2 hrs to fix

    prototype has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    Tabulatr.prototype = {
  constructor: Tabulatr,

  updateTable: function(hash, forceReload) {
    var $table = $('#'+ this.id);
    Severity: Minor
    Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 2 hrs to fix

      Function insertTabulatrData has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        insertTabulatrData: function(response){
    if (typeof response === "string")
      response = JSON.parse(response);

    var tableId = response.meta.table_id;
      Severity: Minor
      Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 1 hr to fix

        Function getDataForAjax has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          getDataForAjax: function(hash){
    var data;
    if(this.initialRequest && this.isAPersistedTable && localStorage[this.id]){
      data = JSON.parse(localStorage[this.id]);
    }else{
        Severity: Minor
        Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function cbfn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        var cbfn = function(event, isInView, visiblePartX, visiblePartY) {
  if (isInView && visiblePartY !== 'top' && visiblePartY !== 'bottom') {
    var tableId = $(event.currentTarget).data('table');
    var table_obj;
    for(var i = 0; i < tabulatr_tables.length; i++){
        Severity: Minor
        Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function insertTabulatrData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          insertTabulatrData: function(response){
    if (typeof response === "string")
      response = JSON.parse(response);

    var tableId = response.meta.table_id;
        Severity: Minor
        Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function readParamsFromForm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          readParamsFromForm: function(hash){
    var form_array = $('.tabulatr_filter_form[data-table="'+ this.id +'"]')
      .find('input:visible,select:visible,input[type=hidden]').serializeArray();
    for(var i = 0; i < form_array.length; i++){
      if(hash[form_array[i].name] !== undefined){
        Severity: Minor
        Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function retrievePage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          retrievePage: function(table, hash){
    table.find('tbody tr').hide();
    if(table.find('tbody tr[data-page='+ hash.page +']').length > 0){
      table.find('tbody tr[data-page='+ hash.page +']').show();
        Severity: Minor
        Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getPageParams has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          getPageParams: function(hash){
    var pagesize = hash.pagesize;
    if(pagesize === undefined){
      pagesize = $('table#'+ this.id).data('pagesize');
    }
        Severity: Minor
        Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepareTableForInsert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          prepareTableForInsert: function(tableId, append, dataCount, actualCount){
    if(!append){
      if(this.storePage){
        $('#'+ tableId +' tbody tr').hide();
      }else{
        Severity: Minor
        Found in app/assets/javascripts/tabulatr/_tabulatr.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

            for(var i = 0; i < tabulatr_tables.length; i++){
      if(tabulatr_tables[i].id === tableId){
        table_obj = tabulatr_tables[i];
      }
    }
        Severity: Major
        Found in app/assets/javascripts/tabulatr/_tabulatr.js and 9 other locations - About 1 hr to fix
        app/assets/javascripts/tabulatr/_events.js on lines 11..15
        app/assets/javascripts/tabulatr/_events.js on lines 57..61
        app/assets/javascripts/tabulatr/_events.js on lines 72..76
        app/assets/javascripts/tabulatr/_events.js on lines 96..100
        app/assets/javascripts/tabulatr/_events.js on lines 108..112
        app/assets/javascripts/tabulatr/_events.js on lines 131..135
        app/assets/javascripts/tabulatr/_events.js on lines 166..170
        app/assets/javascripts/tabulatr/_events.js on lines 222..226
        app/assets/javascripts/tabulatr/_events.js on lines 251..255

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status