Sign upLogin

metanorma/metanorma-gb

View on GitHub
Star

Showing 12 of 21 total issues

Class Converter has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Converter < ISO::Converter
      def doctype(node)
        type = node.attr("mandate") || "mandatory"
        type = "standard" if type == "mandatory"
        type = "recommendation" if type == "recommended"
Severity: Minor
Found in lib/asciidoctor/gb/front.rb - About 2 hrs to fix

    Method default_fonts has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

          def default_fonts(options)
        script = options[:script] || "Hans"
        scope = options[:scope] || "national"
        {
          bodyfont: (script == "Hans" ? '"SimSun",serif' : '"Cambria",serif'),
    Severity: Minor
    Found in lib/isodoc/gb/word_convert.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method default_fonts has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

          def default_fonts(options)
        script = options[:script] || "Hans"
        scope = options[:scope] || "national"
        {
          bodyfont: (script == "Hans" ? '"SimSun",serif' : '"Cambria",serif'),
    Severity: Minor
    Found in lib/isodoc/gb/html_convert.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method extract_options has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def extract_options(file)
        head = file.sub(/\n\n.*$/m, "\n")
        /\n:standard-logo-img: (?<standardlogoimg>[^\n]+)\n/ =~ head
        /\n:standard-class-img: (?<standardclassimg>[^\n]+)\n/ =~ head
        /\n:standard-issuer-img: (?<standardissuerimg>[^\n]+)\n/ =~ head
    Severity: Minor
    Found in lib/metanorma/gb/processor.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_scope has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def get_scope(node)
        node.attr("scope") and return node.attr("scope")
        scope = if %r{^[TQ]/}.match node.attr("prefix")
                  m = node.attr("prefix").split(%{/})
                  mandate = m[0] == "T" ? "social-group" :
    Severity: Minor
    Found in lib/asciidoctor/gb/front.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_bilingual has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_bilingual(t, element)
        zh = t.at(".//#{element}[@language = 'zh']")
        en = t.at(".//#{element}[@language = 'en']")
        (en.nil? || en.text.empty?) && !(zh.nil? || zh.text.empty?) &&
          @log.add("Style", t, "GB: #{element} term #{zh.text} has no English counterpart")
    Severity: Minor
    Found in lib/asciidoctor/gb/validate.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method output has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def output(isodoc_node, inname, outname, format, options={})
    Severity: Minor
    Found in lib/metanorma/gb/processor.rb - About 35 mins to fix

      Method xref_init has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def xref_init(lang, script, klass, labels, options)
      Severity: Minor
      Found in lib/isodoc/gb/init.rb - About 35 mins to fix

        Method status_abbrev_cn has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def status_abbrev_cn(stage, _substage, iter, draft, doctype)
        Severity: Minor
        Found in lib/isodoc/gb/metadata.rb - About 35 mins to fix

          Method norm_bibitem_style has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def norm_bibitem_style(root)
        root.xpath(NORM_BIBITEMS).each do |b|
          if b.at(Asciidoctor::Standoc::Converter::ISO_PUBLISHER_XPATH).nil?
            unless /^#{GBCODE}(?![A-Z])/.match(b.at("./docidentifier").text)
              @log.add("Bibliography", b, "#{NORM_ISO_WARN}: #{b.text}")
          Severity: Minor
          Found in lib/asciidoctor/gb/validate.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method example_table_parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def example_table_parse(node, out)
        out.table **attr_code(id: node["id"], class: "example") do |t|
          t.tr do |tr|
            tr.td **EXAMPLE_TBL_ATTR do |td|
              node.at(ns("./name")).children.each { |n| parse(n, td) }
          Severity: Minor
          Found in lib/isodoc/gb/word_convert.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method status_abbrev_cn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def status_abbrev_cn(stage, _substage, iter, draft, doctype)
        return status_abbrev(stage, _substage, iter, draft, doctype) if @lang != "zh"
        stage_num = stage == "PRF" ? "60" : 
          (Asciidoctor::Gb::Converter::STAGE_ABBRS&.invert[stage]&.to_s || "??")
        stage = STAGE_ABBRS_CN[stage_num.to_sym] || "??"
          Severity: Minor
          Found in lib/isodoc/gb/metadata.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language