metanorma/metanorma-standoc

View on GitHub

Showing 61 of 88 total issues

Method pop_floating_title has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def pop_floating_title(xmldoc)
        loop do
          found = false
          xmldoc.xpath("//floating-title").each do |t|
            t.next_element.nil? or next
Severity: Minor
Found in lib/metanorma/standoc/cleanup_section.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method maxcols_validate1 has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def maxcols_validate1(tcell, row, curr, cells2d, maxcols, mode)
Severity: Minor
Found in lib/metanorma/standoc/validate_table.rb - About 45 mins to fix

    Method isorefmatches3_1 has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def isorefmatches3_1(xml, match, code, year, _hasyr, _ref)
    Severity: Minor
    Found in lib/metanorma/standoc/ref.rb - About 45 mins to fix

      Method progress_conv has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def progress_conv(idx, step, total, threshold, msg)
      Severity: Minor
      Found in lib/metanorma/standoc/cleanup_maths.rb - About 35 mins to fix

        Method table_tracker_update has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def table_tracker_update(cells2d, row, curr, rowspan, colspan)
        Severity: Minor
        Found in lib/metanorma/standoc/validate_table.rb - About 35 mins to fix

          Method merge_by_type has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def merge_by_type(old, new, field, attributes, opt = {})
          Severity: Minor
          Found in lib/metanorma/standoc/merge_bibitems.rb - About 35 mins to fix

            Method organization has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def organization(org, orgname, node = nil, default_org = nil, attrs = {})
            Severity: Minor
            Found in lib/metanorma/standoc/front_organisation.rb - About 35 mins to fix

              Method term_defs_boilerplate has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def term_defs_boilerplate(div, source, term, _preface, isodoc)
              Severity: Minor
              Found in lib/metanorma/standoc/cleanup_boilerplate.rb - About 35 mins to fix

                Method norm_id_memorize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def norm_id_memorize(node, res_table, selector, prefix, use_domain)
                Severity: Minor
                Found in lib/metanorma/standoc/term_lookup_cleanup.rb - About 35 mins to fix

                  Method norm_id_memorize_init has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def norm_id_memorize_init(node, res_table, selector, prefix, use_domain)
                  Severity: Minor
                  Found in lib/metanorma/standoc/term_lookup_cleanup.rb - About 35 mins to fix

                    Method isorefrender1 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          def isorefrender1(bib, match, code, year, allp = "")
                    Severity: Minor
                    Found in lib/metanorma/standoc/ref.rb - About 35 mins to fix

                      Method merge_by_type1 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              def merge_by_type1(old, new, field, attributes, opt)
                      Severity: Minor
                      Found in lib/metanorma/standoc/merge_bibitems.rb - About 35 mins to fix

                        Method output has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                              def output(isodoc_node, inname, outname, format, options = {})
                        Severity: Minor
                        Found in lib/metanorma/standoc/processor.rb - About 35 mins to fix

                          Method admonition_core_attrs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def admonition_core_attrs(node)
                                  { notag: node.attr("notag") == "true" ? "true" : nil,
                                    coverpage: node.attr("coverpage") == "true" ? "true" : nil,
                                    beforeclauses: node.attr("beforeclauses") == "true" ? "true" : nil,
                                    unnumbered: node.attr("unnumbered") ||
                          Severity: Minor
                          Found in lib/metanorma/standoc/blocks_notes.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method mi_italicise? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def mi_italicise?(char)
                                  return false if char.length > 1
                          
                                  case char
                                  when /\p{Greek}/
                          Severity: Minor
                          Found in lib/metanorma/standoc/cleanup_maths.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method move_attrs_to_amend has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def move_attrs_to_amend(clause, amend)
                                  %w(change path path_end title).each do |e|
                                    next unless clause[e]
                          
                                    amend[e] = clause[e]
                          Severity: Minor
                          Found in lib/metanorma/standoc/cleanup_amend.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method sectiontype has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def sectiontype(node, level = true)
                                  ret = sectiontype1(node)
                                  ret1 = preface_main_filter(sectiontype_streamline(ret), node)
                                  ret1 == "symbols and abbreviated terms" and return ret1
                                  !level || node.level == 1 || node.attr("heading") or return nil
                          Severity: Minor
                          Found in lib/metanorma/standoc/section.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method hanging_para_style has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def hanging_para_style(root)
                                  root.xpath("//clause | //annex | //foreword | //introduction | " \
                                             "//acknowledgements").each do |c|
                                    next unless c.at("./clause")
                                    next if c.elements.reject do |n|
                          Severity: Minor
                          Found in lib/metanorma/standoc/validate_section.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method modify_ref_node has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def modify_ref_node(node, target)
                                  node.name = "xref"
                                  s = @lookup[:symbol][target]
                                  t1 = @lookup[:sec2prim][target] and target = norm_ref_id1(t1)
                                  t = @lookup[:term][target]
                          Severity: Minor
                          Found in lib/metanorma/standoc/term_lookup_cleanup.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method ref_dl_cleanup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def ref_dl_cleanup(xmldoc)
                                  xmldoc.xpath("//clause[@bibitem = 'true']").each do |c|
                                    bib = dl_bib_extract(c) or next
                                    validate_ref_dl(bib, c)
                                    bibitemxml = RelatonBib::BibliographicItem.from_hash(bib).to_xml or next
                          Severity: Minor
                          Found in lib/metanorma/standoc/cleanup_asciibib.rb - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language