Sign upLogin

meteor/meteor

View on GitHub
Star
packages/accounts-ui-unstyled/login_buttons_dropdown.js

Summary

Maintainability
D
2 days
Test Coverage

File login_buttons_dropdown.js has 486 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {passwordlessSignupFields, passwordSignupFields} from './accounts_ui.js';
import {
  displayName,
  getLoginServices,
  hasPasswordService,
Severity: Minor
Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 7 hrs to fix

    Function fields has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      fields: () => {
    const loginFields = [
      {fieldName: 'username-or-email', fieldLabel: 'Username or Email',
        autocomplete: 'username email',
        visible: () => isInPasswordSignupFields(
    Severity: Minor
    Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 1 hr to fix

      Function loginOrSignupPasswordless has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const loginOrSignupPasswordless = () => {
  loginButtonsSession.resetMessages();

  if (loginButtonsSession.get('inPasswordlessConfirmation')) {
    const token = trimmedElementValueById('login-code-passwordless');
      Severity: Minor
      Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 1 hr to fix

        Function fields has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          fields: () => {
    const { username, emails } = Meteor.user()
    let email;
    if (emails) {
      email = emails[0].address;
        Severity: Minor
        Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 1 hr to fix

          Function login has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const login = () => {
  loginButtonsSession.resetMessages();

  const username = trimmedElementValueById('login-username');
  const email = trimmedElementValueById('login-email');
          Severity: Minor
          Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 1 hr to fix

            Function signup has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const signup = () => {
  loginButtonsSession.resetMessages();

  const options = {}; // to be passed to Accounts.createUser
            Severity: Minor
            Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 1 hr to fix

              Function login has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              const login = () => {
  loginButtonsSession.resetMessages();

  const username = trimmedElementValueById('login-username');
  const email = trimmedElementValueById('login-email');
              Severity: Minor
              Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function click #back-to-login-link has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                'click #back-to-login-link': () => {
    loginButtonsSession.resetMessages();

    const username = trimmedElementValueById('login-username');
    const email = trimmedElementValueById('login-email')
              Severity: Minor
              Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function signup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              const signup = () => {
  loginButtonsSession.resetMessages();

  const options = {}; // to be passed to Accounts.createUser
              Severity: Minor
              Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function additionalClasses has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                additionalClasses: () => {
    if (!hasPasswordService() || !hasPasswordlessService()) {
      return false;
    } else {
      if (loginButtonsSession.get('inSignupFlow')) {
              Severity: Minor
              Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function click #signup-link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                'click #signup-link': () => {
    loginButtonsSession.resetMessages();

    // store values of fields before swtiching to the signup form
    const username = trimmedElementValueById('login-username');
              Severity: Minor
              Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              const isInPasswordlessSignupFields = (fieldOrFields) => {
  const signupFields = passwordlessSignupFields();

  if (Array.isArray(fieldOrFields)) {
    return signupFields.reduce(
              Severity: Major
              Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js and 1 other location - About 2 hrs to fix
              packages/accounts-ui-unstyled/login_buttons_dropdown.js on lines 222..233

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              const isInPasswordSignupFields = (fieldOrFields) => {
  const signupFields = passwordSignupFields();

  if (Array.isArray(fieldOrFields)) {
    return signupFields.reduce(
              Severity: Major
              Found in packages/accounts-ui-unstyled/login_buttons_dropdown.js and 1 other location - About 2 hrs to fix
              packages/accounts-ui-unstyled/login_buttons_dropdown.js on lines 235..246

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status