Sign upLogin

meteor/meteor

View on GitHub
Star
packages/allow-deny/allow-deny.js

Summary

Maintainability
D
1 day
Test Coverage

File allow-deny.js has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

///
/// Remote methods and access control.
///

const hasOwn = Object.prototype.hasOwnProperty;
Severity: Minor
Found in packages/allow-deny/allow-deny.js - About 3 hrs to fix

    Function _defineMutationMethods has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    CollectionPrototype._defineMutationMethods = function(options) {
  const self = this;
  options = options || {};

  // set to true once we call any allow or deny methods. If true, use
    Severity: Major
    Found in packages/allow-deny/allow-deny.js - About 2 hrs to fix

      Function _validatedUpdate has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      CollectionPrototype._validatedUpdate = function(
    userId, selector, mutator, options) {
  const self = this;

  check(mutator, Object);
      Severity: Major
      Found in packages/allow-deny/allow-deny.js - About 2 hrs to fix

        Function methodName has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              m[methodName] = function (/* ... */) {
        // All the methods do their own validation, instead of using check().
        check(arguments, [Match.Any]);
        const args = Array.from(arguments);
        try {
        Severity: Minor
        Found in packages/allow-deny/allow-deny.js - About 1 hr to fix

          Function addValidator has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function addValidator(collection, allowOrDeny, options) {
  // validate keys
  const validKeysRegEx = /^(?:insert|update|remove|fetch|transform)$/;
  Object.keys(options).forEach((key) => {
    if (!validKeysRegEx.test(key))
          Severity: Minor
          Found in packages/allow-deny/allow-deny.js - About 1 hr to fix

            Function _validatedUpdate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            CollectionPrototype._validatedUpdate = function(
    userId, selector, mutator, options) {
  const self = this;

  check(mutator, Object);
            Severity: Minor
            Found in packages/allow-deny/allow-deny.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              if (!self._validators.fetchAllFields) {
    findOptions.fields = {};
    self._validators.fetch.forEach((fieldName) => {
      findOptions.fields[fieldName] = 1;
    });
            Severity: Major
            Found in packages/allow-deny/allow-deny.js and 1 other location - About 1 hr to fix
            packages/allow-deny/allow-deny.js on lines 383..388

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              if (!self._validators.fetchAllFields) {
    findOptions.fields = {};
    self._validators.fetch.forEach((fieldName) => {
      findOptions.fields[fieldName] = 1;
    });
            Severity: Major
            Found in packages/allow-deny/allow-deny.js and 1 other location - About 1 hr to fix
            packages/allow-deny/allow-deny.js on lines 322..327

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status