Sign upLogin

meteor/meteor

View on GitHub
Star
packages/autoupdate/autoupdate_client.js

Summary

Maintainability
D
2 days
Test Coverage

Function _retrySubscription has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

Autoupdate._retrySubscription = () => {
  Meteor.subscribe("meteor_autoupdate_clientVersions", {
    onError(error) {
      Meteor._debug("autoupdate subscription failed", error);
      failures++;
Severity: Minor
Found in packages/autoupdate/autoupdate_client.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _retrySubscription has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Autoupdate._retrySubscription = () => {
  Meteor.subscribe("meteor_autoupdate_clientVersions", {
    onError(error) {
      Meteor._debug("autoupdate subscription failed", error);
      failures++;
Severity: Major
Found in packages/autoupdate/autoupdate_client.js - About 3 hrs to fix

    Function onReady has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        onReady() {
      // Call checkNewVersionDocument with a slight delay, so that the
      // const handle declaration is guaranteed to be initialized, even if
      // the added or changed callbacks are called synchronously.
      const resolved = Promise.resolve();
    Severity: Major
    Found in packages/autoupdate/autoupdate_client.js - About 3 hrs to fix

      Function checkNewVersionDocument has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            function checkNewVersionDocument(doc) {
        if (doc._id !== clientArch) {
          return;
        }
      Severity: Major
      Found in packages/autoupdate/autoupdate_client.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            onError(error) {
      Meteor._debug("autoupdate subscription failed", error);
      failures++;
      retry.retryLater(failures, function () {
        // Just retry making the subscription, don't reload the whole
        Severity: Major
        Found in packages/autoupdate/autoupdate_client.js and 1 other location - About 1 hr to fix
        packages/autoupdate/autoupdate_cordova.js on lines 48..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status