Sign upLogin

meteor/meteor

View on GitHub
Star
packages/deprecated/amplify/amplify.js

Summary

Maintainability
F
3 days
Test Coverage

File amplify.js has 647 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Amplify 1.1.2
 *
 * Copyright 2011 - 2013 appendTo LLC. (http://appendto.com/team)
 * Dual licensed under the MIT or GPL licenses.
Severity: Major
Found in packages/deprecated/amplify/amplify.js - About 1 day to fix

    Function ajax has 108 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    amplify.request.types.ajax = function( defnSettings ) {
    defnSettings = $.extend({
        type: "GET"
    }, defnSettings );
    Severity: Major
    Found in packages/deprecated/amplify/amplify.js - About 4 hrs to fix

      Function createFromStorageInterface has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createFromStorageInterface( storageType, storage ) {
    store.addType( storageType, function( key, value, options ) {
        var storedValue, parsed, i, remove,
            ret = value,
            now = (new Date()).getTime();
      Severity: Major
      Found in packages/deprecated/amplify/amplify.js - About 2 hrs to fix

        Function subscribe has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            subscribe: function( topic, context, callback, priority ) {
        if ( typeof topic !== "string" ) {
            throw new Error( "You must provide a valid topic to create a subscription." );
        }
        Severity: Minor
        Found in packages/deprecated/amplify/amplify.js - About 1 hr to fix

          Function request has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          amplify.request = function( resourceId, data, callback ) {
    // default to an empty hash just so we can handle a missing resourceId
    // in one place
    var settings = resourceId || {};
          Severity: Minor
          Found in packages/deprecated/amplify/amplify.js - About 1 hr to fix

            Function jsend has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                jsend: function( data, status, ampXHR, success, error ) {
            Severity: Minor
            Found in packages/deprecated/amplify/amplify.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( value === undefined ) {
            storedValue = storage.getItem( key );
            parsed = storedValue ? JSON.parse( storedValue ) : { expires: -1 };
            if ( parsed.expires && parsed.expires <= now ) {
                storage.removeItem( key );
              Severity: Major
              Found in packages/deprecated/amplify/amplify.js and 1 other location - About 2 hrs to fix
              packages/deprecated/amplify/amplify.js on lines 321..341

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 93.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( value === undefined ) {
            attr = div.getAttribute( key );
            parsed = attr ? JSON.parse( attr ) : { expires: -1 };
            if ( parsed.expires && parsed.expires <= now ) {
                div.removeAttribute( key );
              Severity: Major
              Found in packages/deprecated/amplify/amplify.js and 1 other location - About 2 hrs to fix
              packages/deprecated/amplify/amplify.js on lines 193..222

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 93.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  settings.success = async( function( data, status ) {
        status = status || "success";
        amplify.publish( "request.success", settings, data, status );
        amplify.publish( "request.complete", settings, data, status );
        success( data, status );
              Severity: Major
              Found in packages/deprecated/amplify/amplify.js and 1 other location - About 1 hr to fix
              packages/deprecated/amplify/amplify.js on lines 473..478

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 69.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  settings.error = async( function( data, status ) {
        status = status || "error";
        amplify.publish( "request.error", settings, data, status );
        amplify.publish( "request.complete", settings, data, status );
        error( data, status );
              Severity: Major
              Found in packages/deprecated/amplify/amplify.js and 1 other location - About 1 hr to fix
              packages/deprecated/amplify/amplify.js on lines 466..471

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 69.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status