Sign upLogin

meteor/meteor

View on GitHub
Star
packages/deprecated/fastclick/fastclick.js

Summary

Maintainability
F
4 days
Test Coverage

Function notNeeded has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    FastClick.notNeeded = function(layer) {
        var metaViewport;
        var chromeVersion;
        var blackberryVersion;
        var firefoxVersion;
Severity: Minor
Found in packages/deprecated/fastclick/fastclick.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File fastclick.js has 398 lines of code (exceeds 250 allowed). Consider refactoring.
Open

    /**
     * @preserve FastClick: polyfill to remove click delays on browsers with touch UIs.
     *
     * @codingstandard ftlabs-jsv2
     * @copyright The Financial Times Limited [All Rights Reserved]
Severity: Minor
Found in packages/deprecated/fastclick/fastclick.js - About 5 hrs to fix

    Function onTouchEnd has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        FastClick.prototype.onTouchEnd = function(event) {
        var forElement, trackingClickStart, targetTagName, scrollParent, touch, targetElement = this.targetElement;

        if (!this.trackingClick) {
            return true;
    Severity: Minor
    Found in packages/deprecated/fastclick/fastclick.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function FastClick has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        function FastClick(layer, options) {
    'use strict';
        var oldOnClick;

        options = options || {};
    Severity: Minor
    Found in packages/deprecated/fastclick/fastclick.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function FastClick has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function FastClick(layer, options) {
    'use strict';
        var oldOnClick;

        options = options || {};
    Severity: Major
    Found in packages/deprecated/fastclick/fastclick.js - About 2 hrs to fix

      Function onTouchEnd has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          FastClick.prototype.onTouchEnd = function(event) {
        var forElement, trackingClickStart, targetTagName, scrollParent, touch, targetElement = this.targetElement;

        if (!this.trackingClick) {
            return true;
      Severity: Major
      Found in packages/deprecated/fastclick/fastclick.js - About 2 hrs to fix

        Function notNeeded has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            FastClick.notNeeded = function(layer) {
        var metaViewport;
        var chromeVersion;
        var blackberryVersion;
        var firefoxVersion;
        Severity: Major
        Found in packages/deprecated/fastclick/fastclick.js - About 2 hrs to fix

          Function onTouchStart has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              FastClick.prototype.onTouchStart = function(event) {
        var targetElement, touch, selection;

        // Ignore multiple touches, otherwise pinch-to-zoom is prevented if both fingers are on the FastClick element (issue #111).
        if (event.targetTouches.length > 1) {
          Severity: Minor
          Found in packages/deprecated/fastclick/fastclick.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function onTouchStart has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              FastClick.prototype.onTouchStart = function(event) {
        var targetElement, touch, selection;

        // Ignore multiple touches, otherwise pinch-to-zoom is prevented if both fingers are on the FastClick element (issue #111).
        if (event.targetTouches.length > 1) {
          Severity: Minor
          Found in packages/deprecated/fastclick/fastclick.js - About 1 hr to fix

            Function updateScrollParent has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                FastClick.prototype.updateScrollParent = function(targetElement) {
        var scrollParent, parentElement;

        scrollParent = targetElement.fastClickScrollParent;
            Severity: Minor
            Found in packages/deprecated/fastclick/fastclick.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function onMouse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                FastClick.prototype.onMouse = function(event) {

        // If a target element was never set (because a touch event was never fired) allow the event
        if (!this.targetElement) {
            return true;
            Severity: Minor
            Found in packages/deprecated/fastclick/fastclick.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                    return false;
            Severity: Major
            Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return true;
              Severity: Major
              Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                        return true;
                Severity: Major
                Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return false;
                  Severity: Major
                  Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return true;
                    Severity: Major
                    Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return true;
                      Severity: Major
                      Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return false;
                        Severity: Major
                        Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return false;
                          Severity: Major
                          Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return true;
                            Severity: Major
                            Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                                      return true;
                              Severity: Major
                              Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                            return true;
                                Severity: Major
                                Found in packages/deprecated/fastclick/fastclick.js - About 30 mins to fix

                                  Function needsClick has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      FastClick.prototype.needsClick = function(target) {
        switch (target.nodeName.toLowerCase()) {

        // Don't send a synthetic click to disabled inputs (issue #62)
        case 'button':
                                  Severity: Minor
                                  Found in packages/deprecated/fastclick/fastclick.js - About 25 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if (deviceIsAndroid) {
            layer.addEventListener('mouseover', this.onMouse, true);
            layer.addEventListener('mousedown', this.onMouse, true);
            layer.addEventListener('mouseup', this.onMouse, true);
        }
                                  Severity: Major
                                  Found in packages/deprecated/fastclick/fastclick.js and 1 other location - About 1 hr to fix
                                  packages/deprecated/fastclick/fastclick.js on lines 713..717

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 55.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if (deviceIsAndroid) {
            layer.removeEventListener('mouseover', this.onMouse, true);
            layer.removeEventListener('mousedown', this.onMouse, true);
            layer.removeEventListener('mouseup', this.onMouse, true);
        }
                                  Severity: Major
                                  Found in packages/deprecated/fastclick/fastclick.js and 1 other location - About 1 hr to fix
                                  packages/deprecated/fastclick/fastclick.js on lines 120..124

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 55.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status