meteor/meteor

View on GitHub
packages/deprecated/http/httpcall_tests.js

Summary

Maintainability
D
2 days
Test Coverage

File httpcall_tests.js has 403 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { HTTP } from 'meteor/http';

// URL prefix for tests to talk to
let _XHR_URL_PREFIX = '/http_test_responder';

Severity: Minor
Found in packages/deprecated/http/httpcall_tests.js - About 5 hrs to fix

    Function do_test has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        const do_test = function (method, url, params, opt_opts, expect_url, expect_body) {
    Severity: Minor
    Found in packages/deprecated/http/httpcall_tests.js - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            expect(function (error, result) {
              test.isFalse(error);
              test.isTrue(result);
              test.equal(result.statusCode, 200);
              const data = result.data;
      Severity: Major
      Found in packages/deprecated/http/httpcall_tests.js and 1 other location - About 3 hrs to fix
      packages/deprecated/http/httpcall_tests.js on lines 302..310

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            expect(function (error, result) {
              test.isFalse(error);
              test.isTrue(result);
              test.equal(result.statusCode, 200);
              const data = result.data;
      Severity: Major
      Found in packages/deprecated/http/httpcall_tests.js and 1 other location - About 3 hrs to fix
      packages/deprecated/http/httpcall_tests.js on lines 318..326

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (Meteor.isServer) {
            // test sync version
            try {
              const timeoutResult = HTTP.call('GET', timeoutUrl, { timeout: 500 });
              timeoutCallback(undefined, timeoutResult);
      Severity: Major
      Found in packages/deprecated/http/httpcall_tests.js and 1 other location - About 1 hr to fix
      packages/deprecated/http/httpcall_tests.js on lines 194..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (Meteor.isServer) {
            // test sync version
            try {
              const noTimeoutResult = HTTP.call('GET', noTimeoutUrl, { timeout: 2000 });
              noTimeoutCallback(undefined, noTimeoutResult);
      Severity: Major
      Found in packages/deprecated/http/httpcall_tests.js and 1 other location - About 1 hr to fix
      packages/deprecated/http/httpcall_tests.js on lines 171..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status