Sign upLogin

meteor/meteor

View on GitHub
Star
packages/deprecated/jquery-history/history.html4.js

Summary

Maintainability
D
2 days
Test Coverage

Function initHtml4 has 232 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    History.initHtml4 = function(){
        // Initialise
        if ( typeof History.initHtml4.initialized !== 'undefined' ) {
            // Already Loaded
            return false;
Severity: Major
Found in packages/deprecated/jquery-history/history.html4.js - About 1 day to fix

    Function hashChangeInit has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                History.hashChangeInit = function(){
                // Define our Checker Function
                History.checkerFunction = null;

                // Define some variables that will help in our checker function
    Severity: Major
    Found in packages/deprecated/jquery-history/history.html4.js - About 2 hrs to fix

      Function pushState has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  History.pushState = function(data,title,url,queue){
                //History.debug('History.pushState: called', arguments);

                // Check the State
                if ( History.getHashByUrl(url) ) {
      Severity: Minor
      Found in packages/deprecated/jquery-history/history.html4.js - About 1 hr to fix

        Function onHashChange has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    History.onHashChange = function(event){
                //History.debug('History.onHashChange', arguments);

                // Prepare
                var currentUrl = ((event && event.newURL) || document.location.href),
        Severity: Minor
        Found in packages/deprecated/jquery-history/history.html4.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                          return true;
          Severity: Major
          Found in packages/deprecated/jquery-history/history.html4.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    History.getHashByIndex = function(index){
            // Prepare
            var hash = null;

            // Handle
            Severity: Major
            Found in packages/deprecated/jquery-history/history.html4.js and 1 other location - About 5 hrs to fix
            packages/deprecated/jquery-history/history.js on lines 1010..1030

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 147.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ( typeof History.initHtml4.initialized !== 'undefined' ) {
            // Already Loaded
            return false;
        }
        else {
            Severity: Minor
            Found in packages/deprecated/jquery-history/history.html4.js and 1 other location - About 50 mins to fix
            packages/deprecated/jquery-history/history.js on lines 66..72

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status