Sign upLogin

meteor/meteor

View on GitHub
Star
packages/ejson/ejson.js

Summary

Maintainability
F
3 days
Test Coverage

File ejson.js has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  isFunction,
  isObject,
  keysOf,
  lengthOf,
Severity: Minor
Found in packages/ejson/ejson.js - About 5 hrs to fix

    Function equals has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

    EJSON.equals = (a, b, options) => {
  let i;
  const keyOrderSensitive = !!(options && options.keyOrderSensitive);
  if (a === b) {
    return true;
    Severity: Minor
    Found in packages/ejson/ejson.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function equals has 87 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    EJSON.equals = (a, b, options) => {
  let i;
  const keyOrderSensitive = !!(options && options.keyOrderSensitive);
  if (a === b) {
    return true;
    Severity: Major
    Found in packages/ejson/ejson.js - About 3 hrs to fix

      Function clone has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      EJSON.clone = v => {
  let ret;
  if (!isObject(v)) {
    return v;
  }
      Severity: Minor
      Found in packages/ejson/ejson.js - About 1 hr to fix

        Function clone has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        EJSON.clone = v => {
  let ret;
  if (!isObject(v)) {
    return v;
  }
        Severity: Minor
        Found in packages/ejson/ejson.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function fromJSONValueHelper has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        const fromJSONValueHelper = value => {
  if (isObject(value) && value !== null) {
    const keys = keysOf(value);
    if (keys.length <= 2
        && keys.every(k => typeof k === 'string' && k.substr(0, 1) === '$')) {
        Severity: Minor
        Found in packages/ejson/ejson.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return v.clone();
        Severity: Major
        Found in packages/ejson/ejson.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return false;
          Severity: Major
          Found in packages/ejson/ejson.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return ret;
            Severity: Major
            Found in packages/ejson/ejson.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return v.map(EJSON.clone);
              Severity: Major
              Found in packages/ejson/ejson.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return false;
                Severity: Major
                Found in packages/ejson/ejson.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return false;
                  Severity: Major
                  Found in packages/ejson/ejson.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return false;
                    Severity: Major
                    Found in packages/ejson/ejson.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                        return ret && i === bKeys.length;
                      Severity: Major
                      Found in packages/ejson/ejson.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return b.equals(a, options);
                        Severity: Major
                        Found in packages/ejson/ejson.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                            return ret;
                          Severity: Major
                          Found in packages/ejson/ejson.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return false;
                            Severity: Major
                            Found in packages/ejson/ejson.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                  return Array.from(v).map(EJSON.clone);
                              Severity: Major
                              Found in packages/ejson/ejson.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                    return a.valueOf() === b.valueOf();
                                Severity: Major
                                Found in packages/ejson/ejson.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                      return a.equals(b, options);
                                  Severity: Major
                                  Found in packages/ejson/ejson.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                        return true;
                                    Severity: Major
                                    Found in packages/ejson/ejson.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                          return true;
                                      Severity: Major
                                      Found in packages/ejson/ejson.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                            return EJSON.fromJSONValue(EJSON.clone(EJSON.toJSONValue(v)), true);
                                        Severity: Major
                                        Found in packages/ejson/ejson.js - About 30 mins to fix

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                            for (let i = 0; i < builtinConverters.length; i++) {
    const converter = builtinConverters[i];
    if (converter.matchObject(item)) {
      return converter.toJSONValue(item);
    }
                                          Severity: Major
                                          Found in packages/ejson/ejson.js and 1 other location - About 1 hr to fix
                                          packages/ejson/ejson.js on lines 319..324

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 64.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                                for (let i = 0; i < builtinConverters.length; i++) {
        const converter = builtinConverters[i];
        if (converter.matchJSONValue(value)) {
          return converter.fromJSONValue(value);
        }
                                          Severity: Major
                                          Found in packages/ejson/ejson.js and 1 other location - About 1 hr to fix
                                          packages/ejson/ejson.js on lines 242..247

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 64.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          There are no issues that match your filters.

                                          Category
                                          Status