Sign upLogin

meteor/meteor

View on GitHub
Star
packages/shell-server/shell-server.js

Summary

Maintainability
C
1 day
Test Coverage

File shell-server.js has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import assert from "assert";
import { join as pathJoin } from "path";
import { PassThrough } from "stream";
import {
  closeSync,
Severity: Minor
Found in packages/shell-server/shell-server.js - About 3 hrs to fix

    Function onConnection has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      onConnection(socket) {
    // Make sure this function doesn't try to write anything to the socket
    // after it has been closed.
    socket.on("close", function() {
      socket = null;
    Severity: Major
    Found in packages/shell-server/shell-server.js - About 3 hrs to fix

      Function readJSONFromStream has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function readJSONFromStream(inputStream, callback) {
  const outputStream = new PassThrough();
  let dataSoFar = "";

  function onData(buffer) {
      Severity: Minor
      Found in packages/shell-server/shell-server.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function enableInteractiveMode has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        enableInteractiveMode(options) {
    // History persists across shell sessions!
    this.initializeHistory();

    const repl = this.repl;
      Severity: Minor
      Found in packages/shell-server/shell-server.js - About 1 hr to fix

        Function readJSONFromStream has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function readJSONFromStream(inputStream, callback) {
  const outputStream = new PassThrough();
  let dataSoFar = "";

  function onData(buffer) {
        Severity: Minor
        Found in packages/shell-server/shell-server.js - About 1 hr to fix

          Function enableInteractiveMode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            enableInteractiveMode(options) {
    // History persists across shell sessions!
    this.initializeHistory();

    const repl = this.repl;
          Severity: Minor
          Found in packages/shell-server/shell-server.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status