Sign upLogin

meteor/meteor

View on GitHub
Star
tools/isobuild/build-plugin.js

Summary

Maintainability
D
2 days
Test Coverage

File build-plugin.js has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var archinfo = require('../utils/archinfo');
var buildmessage = require('../utils/buildmessage.js');
var files = require('../fs/files');
var _ = require('underscore');
import utils from '../utils/utils.js';
Severity: Minor
Found in tools/isobuild/build-plugin.js - About 4 hrs to fix

    Function constructor has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

      constructor(type, {
    legacyHandler,
    extension,
    sourceProcessors,
    usesDefaultSourceProcessor,
    Severity: Minor
    Found in tools/isobuild/build-plugin.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructor has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructor(type, {
    legacyHandler,
    extension,
    sourceProcessors,
    usesDefaultSourceProcessor,
    Severity: Major
    Found in tools/isobuild/build-plugin.js - About 2 hrs to fix

      Function classifyFilename has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        classifyFilename(filename, arch) {
    // First check to see if a plugin registered for this exact filename.
    if (this._byFilename.hasOwnProperty(filename)) {
      return new SourceClassification('filename', {
        arch,
      Severity: Minor
      Found in tools/isobuild/build-plugin.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function classifyFilename has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        classifyFilename(filename, arch) {
    // First check to see if a plugin registered for this exact filename.
    if (this._byFilename.hasOwnProperty(filename)) {
      return new SourceClassification('filename', {
        arch,
      Severity: Minor
      Found in tools/isobuild/build-plugin.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

            return new SourceClassification('unmatched');
        Severity: Major
        Found in tools/isobuild/build-plugin.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return new SourceClassification('legacy-handler', {
          extension,
          legacyHandler: legacy.handler,
          legacyIsTemplate: legacy.isTemplate
        });
          Severity: Major
          Found in tools/isobuild/build-plugin.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return new SourceClassification('wrong-arch');
            Severity: Major
            Found in tools/isobuild/build-plugin.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                getByExtension(extension) {
    if (this._allowConflicts) {
      throw Error("Can't call getByExtension for linters");
    }
              Severity: Major
              Found in tools/isobuild/build-plugin.js and 1 other location - About 1 hr to fix
              tools/isobuild/build-plugin.js on lines 190..199

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                getByFilename(filename) {
    if (this._allowConflicts) {
      throw Error("Can't call getByFilename for linters");
    }
              Severity: Major
              Found in tools/isobuild/build-plugin.js and 1 other location - About 1 hr to fix
              tools/isobuild/build-plugin.js on lines 178..187

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status