Sign upLogin

meteor/meteor

View on GitHub
Star
tools/isobuild/isopack-cache.js

Summary

Maintainability
D
3 days
Test Coverage

File isopack-cache.js has 392 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var _ = require('underscore');

var buildmessage = require('../utils/buildmessage.js');
var compiler = require('./compiler.js');
var files = require('../fs/files');
Severity: Minor
Found in tools/isobuild/isopack-cache.js - About 5 hrs to fix

    Function _ensurePackageLoaded has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _ensurePackageLoaded(name, onStack) {
    var self = this;
    buildmessage.assertInCapture();
    if (_.has(self._isopacks, name)) {
      return;
    Severity: Major
    Found in tools/isobuild/isopack-cache.js - About 3 hrs to fix

      IsopackCache has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      export class IsopackCache {
  constructor(options) {
    var self = this;
    options = options || {};
      Severity: Minor
      Found in tools/isobuild/isopack-cache.js - About 2 hrs to fix

        Function _loadLocalPackage has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _loadLocalPackage(name, packageInfo, previousIsopack) {
    var self = this;
    buildmessage.assertInCapture();
    buildmessage.enterJob("building package " + name, function () {
      var isopack;
        Severity: Major
        Found in tools/isobuild/isopack-cache.js - About 2 hrs to fix

          Function _ensurePackageLoaded has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

            _ensurePackageLoaded(name, onStack) {
    var self = this;
    buildmessage.assertInCapture();
    if (_.has(self._isopacks, name)) {
      return;
          Severity: Minor
          Found in tools/isobuild/isopack-cache.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                if ((packageInfo.kind === 'versioned' &&
           previousInfo.kind === 'versioned' &&
           packageInfo.version === previousInfo.version) ||
          (packageInfo.kind === 'local' &&
           previousInfo.kind === 'local' &&
          Severity: Major
          Found in tools/isobuild/isopack-cache.js - About 40 mins to fix

            Avoid too many return statements within this function.
            Open

                return watch.isUpToDate(watchSet);
            Severity: Major
            Found in tools/isobuild/isopack-cache.js - About 30 mins to fix

              Function wipeCachedPackages has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                wipeCachedPackages(packages) {
    var self = this;
    if (packages) {
      // Wipe specific packages.
      _.each(packages, function (packageName) {
              Severity: Minor
              Found in tools/isobuild/isopack-cache.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                uses(isopack, name, arch) {
    if (! isopack) {
      return false;
    }
              Severity: Major
              Found in tools/isobuild/isopack-cache.js and 1 other location - About 4 hrs to fix
              tools/isobuild/isopack-cache.js on lines 167..189

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                implies(isopack, name, arch) {
    if (! isopack) {
      return false;
    }
              Severity: Major
              Found in tools/isobuild/isopack-cache.js and 1 other location - About 4 hrs to fix
              tools/isobuild/isopack-cache.js on lines 143..165

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status