Sign upLogin

meteor/meteor

View on GitHub
Star
tools/packaging/tropohouse.js

Summary

Maintainability
F
4 days
Test Coverage

File tropohouse.js has 409 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var _ = require("underscore");
var files = require('../fs/files');
var utils = require('../utils/utils.js');
var httpHelpers = require('../utils/http-helpers.js');
var archinfo = require('../utils/archinfo');
Severity: Minor
Found in tools/packaging/tropohouse.js - About 5 hrs to fix

    Function _makeDownloader has 124 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _makeDownloader: function (options) {
    var self = this;
    buildmessage.assertInJob();

    if (!options.packageName) {
    Severity: Major
    Found in tools/packaging/tropohouse.js - About 4 hrs to fix

      Function download has 83 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var download = function download () {
      buildmessage.assertInCapture();

      Console.debug("Downloading missing local versions of package",
                    packageName + "@" + version, ":", archesToDownload);
      Severity: Major
      Found in tools/packaging/tropohouse.js - About 3 hrs to fix

        Function wipeAllPackages has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          wipeAllPackages: function () {
    var self = this;
    var packagesDirectoryName = config.getPackagesDirectoryName();
    var packageRootDir = files.pathJoin(self.root, packagesDirectoryName);
    var escapedPackages;
        Severity: Major
        Found in tools/packaging/tropohouse.js - About 2 hrs to fix

          Function _extractAndConvert has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports._extractAndConvert = function (packageTarball, forceConvert) {
  var targetDirectory = files.mkdtemp();
  files.extractTarGz(packageTarball, targetDirectory, {
    forceConvert: forceConvert
  });
          Severity: Major
          Found in tools/packaging/tropohouse.js - About 2 hrs to fix

            Function downloadPackagesMissingFromMap has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              downloadPackagesMissingFromMap: function (packageMap, options) {
    var self = this;
    buildmessage.assertInCapture();
    options = options || {};
    var serverArchs = options.serverArchitectures || [archinfo.host()];
            Severity: Minor
            Found in tools/packaging/tropohouse.js - About 2 hrs to fix

              Function wipeAllPackages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                wipeAllPackages: function () {
    var self = this;
    var packagesDirectoryName = config.getPackagesDirectoryName();
    var packageRootDir = files.pathJoin(self.root, packagesDirectoryName);
    var escapedPackages;
              Severity: Minor
              Found in tools/packaging/tropohouse.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _extractAndConvert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              exports._extractAndConvert = function (packageTarball, forceConvert) {
  var targetDirectory = files.mkdtemp();
  files.extractTarGz(packageTarball, targetDirectory, {
    forceConvert: forceConvert
  });
              Severity: Minor
              Found in tools/packaging/tropohouse.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    _.each(convertedMetadata.builds, function (unibuildMeta) {
        var unibuildJsonPath = files.pathJoin(targetDirectory,
                                              unibuildMeta.path);
        var unibuildJson = JSON.parse(files.readFile(unibuildJsonPath));
              Severity: Major
              Found in tools/packaging/tropohouse.js and 1 other location - About 6 hrs to fix
              tools/packaging/tropohouse.js on lines 120..138

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 170.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    _.each(convertedMetadata.plugins, function (pluginMeta) {
        var programJsonPath = files.pathJoin(targetDirectory, pluginMeta.path);
        var programJson = JSON.parse(files.readFile(programJsonPath));

        if (programJson.format !== "javascript-image-pre1") {
              Severity: Major
              Found in tools/packaging/tropohouse.js and 1 other location - About 6 hrs to fix
              tools/packaging/tropohouse.js on lines 98..117

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 170.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status