meteor/meteor

View on GitHub
tools/packaging/updater.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function maybeShowBanners has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

var maybeShowBanners = function () {
  var releaseData = release.current.getCatalogReleaseData();

  var banner = releaseData.banner;
  if (banner) {
Severity: Minor
Found in tools/packaging/updater.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function maybeShowBanners has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var maybeShowBanners = function () {
  var releaseData = release.current.getCatalogReleaseData();

  var banner = releaseData.banner;
  if (banner) {
Severity: Minor
Found in tools/packaging/updater.js - About 1 hr to fix

    Function updateMeteorToolSymlink has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function updateMeteorToolSymlink(printErrors) {
      // Get the latest release version of METEOR. (*Always* of the default
      // track, not of whatever we happen to be running: we always want the tool
      // symlink to go to the default track.)
      var latestReleaseVersion = catalog.official.getDefaultReleaseVersion();
    Severity: Minor
    Found in tools/packaging/updater.js - About 1 hr to fix

      Function updateMeteorToolSymlink has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      export function updateMeteorToolSymlink(printErrors) {
        // Get the latest release version of METEOR. (*Always* of the default
        // track, not of whatever we happen to be running: we always want the tool
        // symlink to go to the default track.)
        var latestReleaseVersion = catalog.official.getDefaultReleaseVersion();
      Severity: Minor
      Found in tools/packaging/updater.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status