Sign upLogin

meteor/meteor

View on GitHub
Star
tools/runners/run-all.js

Summary

Maintainability
F
3 days
Test Coverage

Function run has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

exports.run = function (options) {
  var runOptions = _.clone(options);
  var once = runOptions.once;
  var onBuilt = runOptions.onBuilt;
Severity: Minor
Found in tools/runners/run-all.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File run-all.js has 330 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const _ = require('underscore');

const files = require('../fs/files');
const buildmessage = require('../utils/buildmessage.js');
const utils = require('../utils/utils.js');
Severity: Minor
Found in tools/runners/run-all.js - About 3 hrs to fix

    Function run has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.run = function (options) {
  var runOptions = _.clone(options);
  var once = runOptions.once;
  var onBuilt = runOptions.onBuilt;
    Severity: Major
    Found in tools/runners/run-all.js - About 3 hrs to fix

      Function constructor has 92 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor({
    appHost,
    appPort,
    banner,
    disableOplog,
      Severity: Major
      Found in tools/runners/run-all.js - About 3 hrs to fix

        Function start has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          start() {
    const self = this;

    self.proxy.start();
        Severity: Major
        Found in tools/runners/run-all.js - About 2 hrs to fix

          Function constructor has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

            constructor({
    appHost,
    appPort,
    banner,
    disableOplog,
          Severity: Minor
          Found in tools/runners/run-all.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function start has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

            start() {
    const self = this;

    self.proxy.start();
          Severity: Minor
          Found in tools/runners/run-all.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                if (once ||
          result.outcome === "conflicting-versions" ||
          result.outcome === "wrong-release" ||
          result.outcome === "outdated-cordova-platforms" ||
          result.outcome === "outdated-cordova-plugins" ||
          Severity: Critical
          Found in tools/runners/run-all.js - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                  return result.code;
            Severity: Major
            Found in tools/runners/run-all.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return 254;
              Severity: Major
              Found in tools/runners/run-all.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return 254;
                Severity: Major
                Found in tools/runners/run-all.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return 255;
                  Severity: Major
                  Found in tools/runners/run-all.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return 254;
                    Severity: Major
                    Found in tools/runners/run-all.js - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (self.selenium && ! self.stopped) {
      buildmessage.enterJob({ title: "starting Selenium" }, function () {
        self.selenium.start();
      });
      if (! self.quiet && ! self.stopped) {
                      Severity: Major
                      Found in tools/runners/run-all.js and 1 other location - About 2 hrs to fix
                      tools/runners/run-all.js on lines 204..211

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 82.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (! self.stopped) {
      buildmessage.enterJob({ title: "starting your app" }, function () {
        self.appRunner.start();
      });
      if (! self.quiet && ! self.stopped) {
                      Severity: Major
                      Found in tools/runners/run-all.js and 1 other location - About 2 hrs to fix
                      tools/runners/run-all.js on lines 230..237

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 82.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status