Sign upLogin

meteor/meteor

View on GitHub
Star
tools/runners/run-hmr.js

Summary

Maintainability
D
1 day
Test Coverage

File run-hmr.js has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import WS from 'ws';
import runLog from './run-log.js';
import crypto from 'crypto';
import Anser from "anser";
import { CordovaBuilder } from '../cordova/builder.js';
Severity: Minor
Found in tools/runners/run-hmr.js - About 3 hrs to fix

    Function _handleWsConn has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _handleWsConn(conn, req) {
    let registered = false;
    let connArch = null;
    let fromCordova = this.cordovaOrigin && req.headers.origin === this.cordovaOrigin;
    Severity: Major
    Found in tools/runners/run-hmr.js - About 3 hrs to fix

      Function compare has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        compare({ name, arch, hmrAvailable, files, cacheKey }, getFileOutput) {
    if (this.firstBuild = null) {
      this.firstBuild = Date.now();
    }
      Severity: Major
      Found in tools/runners/run-hmr.js - About 2 hrs to fix

        Function compareFiles has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          compareFiles(previousHashes = new Map(), previousUnreloadable = [], currentFiles) {
    const unreloadable = [];
    const currentHashes = new Map();
    const unseenModules = new Map(previousHashes);
        Severity: Major
        Found in tools/runners/run-hmr.js - About 2 hrs to fix

          Function compare has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            compare({ name, arch, hmrAvailable, files, cacheKey }, getFileOutput) {
    if (this.firstBuild = null) {
      this.firstBuild = Date.now();
    }
          Severity: Minor
          Found in tools/runners/run-hmr.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  fileConfig = JSON.stringify({
          meteorInstallOptions: file.meteorInstallOptions,
          absModuleId: file.absModuleId,
          sourceMap: !!file.sourceMap,
          mainModule: file.mainModule,
          Severity: Major
          Found in tools/runners/run-hmr.js and 1 other location - About 2 hrs to fix
          tools/isobuild/compiler-plugin.js on lines 1700..1709

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status