Sign upLogin

meteor/meteor

View on GitHub
Star
tools/upgraders.js

Summary

Maintainability
D
1 day
Test Coverage

File upgraders.js has 253 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint no-console: 0 */

var _ = require('underscore');
var files = require('./fs/files');
var Console = require('./console/console.js').Console;
Severity: Minor
Found in tools/upgraders.js - About 2 hrs to fix

    Function 1.4.3-split-account-service-packages has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      "1.4.3-split-account-service-packages": function (projectContext) {

    maybePrintNoticeHeader();
    Console.info(
`The account packages for different services (e.g. facebook, twitter, \
    Severity: Minor
    Found in tools/upgraders.js - About 1 hr to fix

      Function notices-for-0.9.0 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

         "notices-for-0.9.0": function (projectContext) {
     maybePrintNoticeHeader();

     var smartJsonPath =
       files.pathJoin(projectContext.projectDir, 'smart.json');
      Severity: Minor
      Found in tools/upgraders.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          '1.7-split-underscore-from-meteor-base': function (projectContext) {
    const packagesFile = projectContext.projectConstraintsFile;
    if (! packagesFile.getConstraint(`underscore`) &&
      packagesFile.getConstraint(`meteor-base`)) {
        Severity: Major
        Found in tools/upgraders.js and 1 other location - About 4 hrs to fix
        tools/upgraders.js on lines 316..333

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          '1.8.3-split-jquery-from-blaze': function (projectContext) {
    const packagesFile = projectContext.projectConstraintsFile;
    if (! packagesFile.getConstraint(`jquery`) &&
      packagesFile.getConstraint(`blaze-html-templates`)) {
        Severity: Major
        Found in tools/upgraders.js and 1 other location - About 4 hrs to fix
        tools/upgraders.js on lines 297..314

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          "1.4.1-add-shell-server-package": function (projectContext) {
    const packagesFile = projectContext.projectConstraintsFile;
    packagesFile.addPackages(["shell-server"]);
    packagesFile.writeIfModified();
  },
        Severity: Minor
        Found in tools/upgraders.js and 1 other location - About 30 mins to fix
        tools/upgraders.js on lines 291..295

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          "1.5-add-dynamic-import-package": function (projectContext) {
    const packagesFile = projectContext.projectConstraintsFile;
    packagesFile.addPackages(["dynamic-import"]);
    packagesFile.writeIfModified();
  },
        Severity: Minor
        Found in tools/upgraders.js and 1 other location - About 30 mins to fix
        tools/upgraders.js on lines 239..243

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status