meteor/meteor

View on GitHub
tools/utils/http-helpers.js

Summary

Maintainability
F
3 days
Test Coverage

Function request has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

  request: function (urlOrOptions, callback) {
    var options;
    if (!_.isObject(urlOrOptions)) {
      options = { url: urlOrOptions };
    } else {
Severity: Minor
Found in tools/utils/http-helpers.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function request has 169 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  request: function (urlOrOptions, callback) {
    var options;
    if (!_.isObject(urlOrOptions)) {
      options = { url: urlOrOptions };
    } else {
Severity: Major
Found in tools/utils/http-helpers.js - About 6 hrs to fix

    File http-helpers.js has 353 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    ///
    /// utility functions for dealing with urls and http
    ///
    
    var os = require('os');
    Severity: Minor
    Found in tools/utils/http-helpers.js - About 4 hrs to fix

      Function getUrlWithResuming has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

        getUrlWithResuming(urlOrOptions) {
          const options = _.isObject(urlOrOptions) ? _.clone(urlOrOptions) : {
            url: urlOrOptions,
          };
      
      
      Severity: Minor
      Found in tools/utils/http-helpers.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getUrlWithResuming has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getUrlWithResuming(urlOrOptions) {
          const options = _.isObject(urlOrOptions) ? _.clone(urlOrOptions) : {
            url: urlOrOptions,
          };
      
      
      Severity: Major
      Found in tools/utils/http-helpers.js - About 2 hrs to fix

        Function attempt has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function attempt(triesRemaining = maxAttempts, startAt = 0) {
              if (startAt > 0) {
                options.headers = {
                  ...options.headers,
                  Range: `bytes=${startAt}-`
        Severity: Minor
        Found in tools/utils/http-helpers.js - About 1 hr to fix

          Function getUserAgent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          var getUserAgent = function () {
            var version;
          
            if (release.current) {
              version = release.current.isCheckout() ? 'checkout' : release.current.name;
          Severity: Minor
          Found in tools/utils/http-helpers.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status