Sign upLogin

miataru/miataru-server

View on GitHub
Star
lib/routes/location/v1/location.js

Summary

Maintainability
D
2 days
Test Coverage

Function updateLocation has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function updateLocation(req, res, next) {
    var MIATARU = req.MIATARU;
    var requestConfig = MIATARU.config;
    var locations = MIATARU.locations;
Severity: Minor
Found in lib/routes/location/v1/location.js - About 1 hr to fix

    Function getLocationHistory has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getLocationHistory(req, res, next) {
    var locationRequest = req.MIATARU.request;
    var requestConfig = req.MIATARU.config;
    var key = kb.build(locationRequest.device(), KEY_HISTORY);
    Severity: Minor
    Found in lib/routes/location/v1/location.js - About 1 hr to fix

      Function getLocation has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getLocation(req, res, next) {
    var chain = seq();
        var requestConfig = req.MIATARU.config;
    var response = new models.ResponseLocation();
      Severity: Minor
      Found in lib/routes/location/v1/location.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (reply != null)
                {
                  // store the visitor for this device (if it's not empty)...
                  var visitKey = kb.build(device.device(), KEY_VISIT);
                  var miataruVisitorObject = requestConfig.requestMiataruVisitorObject();
        Severity: Major
        Found in lib/routes/location/v1/location.js and 1 other location - About 5 hrs to fix
        lib/routes/location/v1/location.js on lines 51..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 148.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (this.vars.listLength != 0)
            {
              // store the visitor for this device (if it's not empty)...
              var visitKey = kb.build(locationRequest.device(), KEY_VISIT);
              var miataruVisitorObject = requestConfig.requestMiataruVisitorObject();
        Severity: Major
        Found in lib/routes/location/v1/location.js and 1 other location - About 5 hrs to fix
        lib/routes/location/v1/location.js on lines 171..191

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 148.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            seq()
        .par('listLength', function() {
            db.llen(key, this);
        })
        .par('list', function() {
        Severity: Major
        Found in lib/routes/location/v1/location.js and 1 other location - About 1 hr to fix
        lib/routes/location/v1/location.js on lines 41..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            seq()
        .par('listLength', function() {
            db.llen(key, this);
        })
        .par('list', function() {
        Severity: Major
        Found in lib/routes/location/v1/location.js and 1 other location - About 1 hr to fix
        lib/routes/location/v1/location.js on lines 273..289

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    res.send((new models.ResponseVisitorHistory(
                this.vars.listLength,
                configuration.maximumNumberOfLocationVistors,
                this.vars.list.map(function(value) {
                    return JSON.parse(value)
        Severity: Major
        Found in lib/routes/location/v1/location.js and 1 other location - About 1 hr to fix
        lib/routes/location/v1/location.js on lines 73..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    res.send((new models.ResponseLocationHistory(
                this.vars.listLength,
                configuration.maximumNumberOfHistoryItems,
                this.vars.list.map(function(value) {
                    return JSON.parse(value)
        Severity: Major
        Found in lib/routes/location/v1/location.js and 1 other location - About 1 hr to fix
        lib/routes/location/v1/location.js on lines 282..288

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status