Sign upLogin

michadenheijer/pynytimes

View on GitHub
Star

Showing 3 of 14 total issues

Function movie_reviews_parse_dates has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def movie_reviews_parse_dates(
    dates: dict[str, Union[datetime.date, datetime.datetime, None]]
) -> dict:
    # Convert datetime.date to datetime.datetime
    for date in dates.items():
Severity: Minor
Found in pynytimes/helpers/movie_reviews.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function tag_query_get_filter_options has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def tag_query_get_filter_options(filter_options) -> Optional[str]:
    # Add filter options
    _filter_options = ""
    if filter_options is not None:
        for filter_opt in filter_options:
Severity: Minor
Found in pynytimes/helpers/tag_query.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse_date has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def parse_date(
    date_string: str,
    date_type: Literal["rfc3339", "date-only", "date-time"],
) -> Union[datetime.datetime, datetime.date, None]:
    """Parse the date into datetime.datetime object"""
Severity: Minor
Found in pynytimes/helpers/dates.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language