Sign upLogin

michahell/pinbored-nwjs

View on GitHub
Star

Showing 13 of 282 total issues

Function exports has 209 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {

  // requirements
  require('load-grunt-tasks')(grunt);
Severity: Major
Found in Gruntfile.js - About 1 day to fix

Function executeStandardRequest has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    this.executeStandardRequest = function(requestString, deferred, additionalOpts, optionalCompleteCallback) {
      
      var requestOptions = {
        url : requestString,
        method : 'GET',
Severity: Major
Found in App/scripts/services/pinboardservice.js - About 3 hrs to fix

File pinboardservice.js has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open


/**
 * @ngdoc service
 * @name pinboredWebkitApp.services.Pinboardservice
 * @description
Severity: Minor
Found in App/scripts/services/pinboardservice.js - About 2 hrs to fix

Function exports has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(config) {
  config.set({

    basePath : './',
Severity: Minor
Found in karma.conf.js - About 1 hr to fix

Function checkDuplicates has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $scope.checkDuplicates = function() {

      // check if we 'have' bookmarks:
      if(Object.keys($scope.duplicatecheck.bookmarks).length === 0) {
        $scope.loadCachedBookmarks();
Severity: Minor
Found in App/scripts/controllers/tools.js - About 1 hr to fix

Function selectionRecursiveDelete has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    this.selectionRecursiveDelete = function(selection) {
      var total = selection.length;
      var deleted = 0;

      console.log('bookmarks to delete: ' + total);
Severity: Minor
Found in App/scripts/services/bookmarkservice.js - About 1 hr to fix

Function req has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        var req = https.get(requestString).on('response', function(res) {
          
          var data = '';
          var trackProgress = false;
Severity: Minor
Found in App/scripts/services/pinboardservice.js - About 1 hr to fix

Function login has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $scope.login = function(username, password) {
      $scope.model.busy = true;

      if(!_.isEmpty(username) && !_.isEmpty(password)) {
        Pinboardservice.checkConnection()
Severity: Minor
Found in App/scripts/controllers/login.js - About 1 hr to fix

Function selectionStaleCheck has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    this.selectionStaleCheck = function(selection) {
      var total = selection.length;
      var checked = 0;
      console.log('bookmarks to stale check: ' + total);
Severity: Minor
Found in App/scripts/services/bookmarkservice.js - About 1 hr to fix

Function selectionDeleteAllTags has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    this.selectionDeleteAllTags = function(selection) {
      var total = selection.length;
      var updated = 0;
      console.log('bookmarks to delete all tags from: ' + total);
Severity: Minor
Found in App/scripts/services/bookmarkservice.js - About 1 hr to fix

Function createTags has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $scope.createTags = function(tagdata) {
      var deferred = $q.defer();
      var tagID = 0;

      for (var tag in tagdata) {
Severity: Minor
Found in App/scripts/controllers/tags.js - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

            for(var m=0; m<searchTags.length; m++) {
              
              var searchTag2 = searchTags[m];
              var bookmarkTags2 = item2.data.tags.split(' ');
              for(var n=0; n<bookmarkTags2.length; n++) {
Severity: Major
Found in App/scripts/filters/bookmarktagsfilter.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

              if(matches === false) {
                var searchTag = searchTags[j];
                var bookmarkTags = item.data.tags.split(' ');
                for(var k=0; k<bookmarkTags.length; k++) {
                  if(bookmarkTags[k] === searchTag.text) {
Severity: Major
Found in App/scripts/filters/bookmarktagsfilter.js - About 45 mins to fix
Severity
Category
Status
Source
Language