Sign upLogin

michielbdejong/solid-panes

View on GitHub
Star
src/outline/dragDrop.js

Summary

Maintainability
C
1 day
Test Coverage

Function DDM has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

dragAndDrop.util.DDM = (function DDM () {
  return {
    handleMouseDown: function (e, oDD) {
      // this.currentTarget = dragAndDrop.util.Event.getTarget(e)
Severity: Minor
Found in src/outline/dragDrop.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DDM has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

dragAndDrop.util.DDM = (function DDM () {
  return {
    handleMouseDown: function (e, oDD) {
      // this.currentTarget = dragAndDrop.util.Event.getTarget(e)
Severity: Major
Found in src/outline/dragDrop.js - About 2 hrs to fix

    Function onDragStart has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      onDragStart: function (x, y, td) {
    /* seeAlso nsDragAndDrop.js::nsDragAndDrop.startDrag */
    // ToDo for myself: understand the connections in firefox, x, screenX

    this.dragTarget = td
    Severity: Minor
    Found in src/outline/dragDrop.js - About 1 hr to fix

      Function Event has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      dragAndDrop.util.Event = (function () {
  var listeners = []
  return {
    on: function (el, sType, fn, obj, fnId /* ,override */) {
      var wrappedFn = function (e) {
      Severity: Minor
      Found in src/outline/dragDrop.js - About 1 hr to fix

        Function onDragEnter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          onDragEnter: function (e, _dragSession) {
    // enter or exit something
    try {
      var selection = UI.utils.ancestor(
        UI.utils.ancestor(e.originalTarget, 'TABLE').parentNode,
        Severity: Minor
        Found in src/outline/dragDrop.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Event has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        dragAndDrop.util.Event = (function () {
  var listeners = []
  return {
    on: function (el, sType, fn, obj, fnId /* ,override */) {
      var wrappedFn = function (e) {
        Severity: Minor
        Found in src/outline/dragDrop.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function on has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            on: function (el, sType, fn, obj, fnId /* ,override */) {
        Severity: Minor
        Found in src/outline/dragDrop.js - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              var selection = UI.utils.ancestor(
      UI.utils.ancestor(e.originalTarget, 'TABLE').parentNode,
      'TABLE'
    ).outline.selection
          Severity: Minor
          Found in src/outline/dragDrop.js and 1 other location - About 40 mins to fix
          src/outline/dragDrop.js on lines 294..297

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                var selection = UI.utils.ancestor(
        UI.utils.ancestor(e.originalTarget, 'TABLE').parentNode,
        'TABLE'
      ).outline.selection
          Severity: Minor
          Found in src/outline/dragDrop.js and 1 other location - About 40 mins to fix
          src/outline/dragDrop.js on lines 260..263

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status