Sign upLogin

michielbdejong/solid-panes

View on GitHub
Star
src/trip/tripPane.js

Summary

Maintainability
D
1 day
Test Coverage

Function render has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  render: function (subject, context) {
    const myDocument = context.dom
    var kb = context.store
    var ns = UI.ns
    var CAL = $rdf.Namespace('http://www.w3.org/2002/12/cal/ical#')
Severity: Minor
Found in src/trip/tripPane.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render: function (subject, context) {
    const myDocument = context.dom
    var kb = context.store
    var ns = UI.ns
    var CAL = $rdf.Namespace('http://www.w3.org/2002/12/cal/ical#')
Severity: Major
Found in src/trip/tripPane.js - About 3 hrs to fix

    Function renderTrip has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var renderTrip = function renderTrip (subject, thisDiv) {
      var query = new $rdf.Query(UI.utils.label(subject))
      var vars = ['date', 'transaction', 'comment', 'type', 'in_USD']
      var v = {}
      vars.map(function (x) {
    Severity: Minor
    Found in src/trip/tripPane.js - About 2 hrs to fix

      Function calculations has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            var calculations = function () {
        var total = {}
        var trans = kb.each(undefined, TRIP('trip'), subject)
        // complain("@@ Number of transactions in this trip: " + trans.length);
        trans.map(function (t) {
      Severity: Minor
      Found in src/trip/tripPane.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var complain = function complain (message, style) {
      if (style === undefined) style = 'color: grey'
      var pre = myDocument.createElement('pre')
      pre.setAttribute('style', style)
      div.appendChild(pre)
        Severity: Major
        Found in src/trip/tripPane.js and 1 other location - About 2 hrs to fix
        src/transaction/pane.js on lines 44..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 87.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              vars.map(function (x) {
        query.vars.push((v[x] = $rdf.variable(x)))
      }) // Only used by UI
        Severity: Minor
        Found in src/trip/tripPane.js and 1 other location - About 35 mins to fix
        src/schedule/schedulePane.js on lines 954..956

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status