microting/eform-sdk-dotnet

View on GitHub

Showing 886 of 3,221 total issues

Method Core_Case_CaseRead_ReadsCase has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task Core_Case_CaseRead_ReadsCase()
        {
            // Arrange

Severity: Minor
Found in eFormSDK.Integration.Case.CoreTests/CoreTestCase.cs - About 1 hr to fix

    Method CheckRead has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Open

            public async Task<ReplyElement> CheckRead(int id, Language language)
            {
                string methodName = "SqlController.CheckRead";
                try
                {
    Severity: Minor
    Found in eFormCore/Infrastructure/SqlController.cs - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method CheckStatusByMicrotingUid has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Open

            private async Task<bool> CheckStatusByMicrotingUid(int microtingUid)
            {
                await using MicrotingDbContext dbContext = _core.DbContextHelper.GetDbContext();
                List<CaseDto> lstCase = new List<CaseDto>();
    
    
    Severity: Minor
    Found in eFormCore/Handlers/EformCompletedHandler.cs - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method SQL_Case_CheckListSitesRead_DoesSiteRead has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
            public async Task SQL_Case_CheckListSitesRead_DoesSiteRead()
            {
                Random rnd = new Random();
                Site site1 = await testHelpers.CreateSite("mySite2", 331);

      Method DoSetup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public override async Task DoSetup()
              {
                  #region Setup SettingsTableContent
      
                  DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
      Severity: Minor
      Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTestAdvanced.cs - About 1 hr to fix

        Method DoSetup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public override async Task DoSetup()
                {
                    #region Setup SettingsTableContent
        
                    DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
        Severity: Minor
        Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTesteForm.cs - About 1 hr to fix

          Method Core_Tags_TemplateSetTags_DoesAssignTagToTemplate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  [Test]
                  public async Task Core_Tags_TemplateSetTags_DoesAssignTagToTemplate()
                  {
                      // Arrance
                      CheckList cl1 = new CheckList
          Severity: Minor
          Found in eFormSDK.Integration.Base.CoreTests/CoreTestTag.cs - About 1 hr to fix

            Method CaseReadFull has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public async Task<Case> CaseReadFull(int microtingUId, int checkUId)
                    {
                        string methodName = "SqlController.CaseReadFull";
                        try
                        {
            Severity: Minor
            Found in eFormCore/Infrastructure/SqlController.cs - About 1 hr to fix

              Method UnitGetAll has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      public async Task<List<UnitDto>> UnitGetAll()
                      {
                          string methodName = "SqlController.UnitGetAll";
                          try
                          {
              Severity: Minor
              Found in eFormCore/Infrastructure/SqlController.cs - About 1 hr to fix

                Method TemplateFromJson has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        public MainElement TemplateFromJson(string json)
                        {
                            if (string.IsNullOrEmpty(json))
                                throw new ArgumentNullException("json cannot be null or empty");
                            string methodName = "Core.TemplateFromXml";
                Severity: Minor
                Found in eFormCore/Core.cs - About 1 hr to fix

                  Method EntityGroupUpdate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          public async Task<bool> EntityGroupUpdate(string entityType, string name, int id, string entityGroupMuId)
                          {
                              _log.LogEverything("Communicator.EntityGroupUpdate", "called");
                              _log.LogVariable("Communicator.EntityGroupUpdate", nameof(entityType), entityType);
                              _log.LogVariable("Communicator.EntityGroupUpdate", nameof(name), name);
                  Severity: Minor
                  Found in eFormCore/Communication/Communicator.cs - About 1 hr to fix

                    Method MapVersions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            private QuestionVersion MapVersions(Question question)
                            {
                                return new QuestionVersion
                                {
                                    QuestionSetId = question.QuestionSetId,
                    Severity: Minor
                    Found in eFormCore/Infrastructure/Data/Entities/Question.cs - About 1 hr to fix

                      Method EntityItemDelete has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              public async Task EntityItemDelete(int id)
                              {
                                  EntityItem et = await _sqlController.EntityItemRead(id);
                                  if (et == null)
                                  {
                      Severity: Minor
                      Found in eFormCore/Core.cs - About 1 hr to fix

                        Method Advanced_UnitRequestOtp has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                public async Task<UnitDto> Advanced_UnitRequestOtp(int microtingUid)
                                {
                                    string methodName = "Core.Advanced_UnitRequestOtp";
                                    try
                                    {
                        Severity: Minor
                        Found in eFormCore/Core.cs - About 1 hr to fix

                          Method Core_Case_CaseReadByCaseId_Returns_cDto has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  [Test]
                                  public async Task Core_Case_CaseReadByCaseId_Returns_cDto()
                                  {
                                      // Arrance
                          
                          
                          Severity: Minor
                          Found in eFormSDK.Integration.Case.CoreTests/CoreTestCase.cs - About 1 hr to fix

                            Method GetFileFromS3Storage has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    public async Task<GetObjectResponse> GetFileFromS3Storage(string fileName, bool isRetry = false)
                                    {
                                        try
                                        {
                                            GetObjectRequest request = new GetObjectRequest
                            Severity: Minor
                            Found in eFormCore/Core.cs - About 1 hr to fix

                              Method Core_Case_CaseLookupCaseUId_Returns_lstDto has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      [Test]
                                      public async Task Core_Case_CaseLookupCaseUId_Returns_lstDto()
                                      {
                                          // Arrance
                              
                              
                              Severity: Minor
                              Found in eFormSDK.Integration.Case.CoreTests/CoreTestCase.cs - About 1 hr to fix

                                Method Advanced_TemplateUpdateFieldIdsForColumns has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                        public async Task<bool> Advanced_TemplateUpdateFieldIdsForColumns(int templateId, int? fieldId1, int? fieldId2,
                                            int? fieldId3, int? fieldId4, int? fieldId5, int? fieldId6, int? fieldId7, int? fieldId8, int? fieldId9,
                                            int? fieldId10)
                                        {
                                            string methodName = "Core.Advanced_TemplateUpdateFieldIdsForColumns";
                                Severity: Minor
                                Found in eFormCore/Core.cs - About 1 hr to fix

                                  Method Core_Case_CaseLookupCaseId_Returns_cDto has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                          [Test]
                                          public async Task Core_Case_CaseLookupCaseId_Returns_cDto()
                                          {
                                              // Arrance
                                  
                                  
                                  Severity: Minor
                                  Found in eFormSDK.Integration.Case.CoreTests/CoreTestCase.cs - About 1 hr to fix

                                    Method Core_Case_CaseLookupMUId_Returns_ReturnCase has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                            [Test]
                                            public async Task Core_Case_CaseLookupMUId_Returns_ReturnCase()
                                            {
                                                // Arrance
                                    
                                    
                                    Severity: Minor
                                    Found in eFormSDK.Integration.Case.CoreTests/CoreTestCase.cs - About 1 hr to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language