microting/eform-sdk-dotnet

View on GitHub

Showing 886 of 3,221 total issues

Method FolderUpdate has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        public Task FolderUpdate(int id, string name, string description, string languageCode, int? parentId)
Severity: Minor
Found in eFormCore/Communication/Communicator.cs - About 35 mins to fix

    Method EntitySearchItemUpdate has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public async Task<bool> EntitySearchItemUpdate(string entitySearchGroupId, string entitySearchItemId,
                string name, string description, string id)
    Severity: Minor
    Found in eFormCore/Communication/Http.cs - About 35 mins to fix

      Method GenerateDataSetFromCasesSubSet has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              private async Task<List<string>> GenerateDataSetFromCasesSubSet(List<string> lstReturn, int? checkListId,
                  string preLabel, Language language, bool includeCheckListText)
      Severity: Minor
      Found in eFormCore/Core.cs - About 35 mins to fix

        Method EntityGroupCreate has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public async Task<Microting.eForm.Infrastructure.Data.Entities.EntityGroup> EntityGroupCreate(string entityType,
                    string name, string description, bool locked, bool editable)
        Severity: Minor
        Found in eFormCore/Core.cs - About 35 mins to fix

          Method EntityGroupAll has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
          Open

                  public async Task<EntityGroupList> EntityGroupAll(string sort, string nameFilter, int offSet, int pageSize,
                      string entityType, bool desc, string workflowState)
                  {
                      if (entityType != Constants.Constants.FieldTypes.EntitySearch &&
                          entityType != Constants.Constants.FieldTypes.EntitySelect)
          Severity: Minor
          Found in eFormCore/Infrastructure/SqlController.cs - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in eFormCore/Core.cs - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language