Sign upLogin

mike-goodwin/owasp-threat-dragon

View on GitHub
Star
td.tests/serverspec/threatmodelrepository_spec.js

Summary

Maintainability
F
4 days
Test Coverage

File threatmodelrepository_spec.js has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

require('jasmine');
var mockery = require('mockery');
var moduleUnderTest = '../../td/repositories/threatmodelrepository';
Severity: Minor
Found in td.tests/serverspec/threatmodelrepository_spec.js - About 3 hrs to fix

    Function updateContents has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                updateContents: function (path, message, content, sha, branch, cb) {
    Severity: Minor
    Found in td.tests/serverspec/threatmodelrepository_spec.js - About 45 mins to fix

      Function deleteContents has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  deleteContents: function (path, message, sha, branch, cb) {
      Severity: Minor
      Found in td.tests/serverspec/threatmodelrepository_spec.js - About 35 mins to fix

        Function createContents has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                    createContents: function (path, message, content, branch, cb) {
        Severity: Minor
        Found in td.tests/serverspec/threatmodelrepository_spec.js - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              it('should error when updating the specified model', function () {

        var testOrg = 'test org';
        var testRepo = 'test repo';
        var testBranch = 'test branch';
          Severity: Major
          Found in td.tests/serverspec/threatmodelrepository_spec.js and 1 other location - About 1 day to fix
          td.tests/serverspec/threatmodelrepository_spec.js on lines 332..365

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 295.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              it('should error when deleting the specified model', function () {

        var testOrg = 'test org';
        var testRepo = 'test repo';
        var testBranch = 'test branch';
          Severity: Major
          Found in td.tests/serverspec/threatmodelrepository_spec.js and 1 other location - About 1 day to fix
          td.tests/serverspec/threatmodelrepository_spec.js on lines 252..285

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 295.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  expect(mockRepo.updateContents.calls.argsFor(0)[0]).toEqual('ThreatDragonModels/' + testModel + '/' + testModel + '.json');
          Severity: Major
          Found in td.tests/serverspec/threatmodelrepository_spec.js and 2 other locations - About 50 mins to fix
          td.tests/serverspec/threatmodelrepository_spec.js on lines 196..196
          td.tests/serverspec/threatmodelrepository_spec.js on lines 322..322

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  expect(mockRepo.deleteContents.calls.argsFor(0)[0]).toEqual('ThreatDragonModels/' + testModel + '/' + testModel + '.json');
          Severity: Major
          Found in td.tests/serverspec/threatmodelrepository_spec.js and 2 other locations - About 50 mins to fix
          td.tests/serverspec/threatmodelrepository_spec.js on lines 196..196
          td.tests/serverspec/threatmodelrepository_spec.js on lines 241..241

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  expect(mockRepo.createContents.calls.argsFor(0)[0]).toEqual('ThreatDragonModels/' + testModel + '/' + testModel + '.json');
          Severity: Major
          Found in td.tests/serverspec/threatmodelrepository_spec.js and 2 other locations - About 50 mins to fix
          td.tests/serverspec/threatmodelrepository_spec.js on lines 241..241
          td.tests/serverspec/threatmodelrepository_spec.js on lines 322..322

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  expect(mockRepo.createContents.calls.argsFor(0)[2]).toEqual(JSON.stringify(testContent, null, '  '));
          Severity: Minor
          Found in td.tests/serverspec/threatmodelrepository_spec.js and 1 other location - About 30 mins to fix
          td.tests/serverspec/threatmodelrepository_spec.js on lines 243..243

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  expect(mockRepo.updateContents.calls.argsFor(0)[2]).toEqual(JSON.stringify(testContent, null, '  '));
          Severity: Minor
          Found in td.tests/serverspec/threatmodelrepository_spec.js and 1 other location - About 30 mins to fix
          td.tests/serverspec/threatmodelrepository_spec.js on lines 198..198

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status