Sign upLogin

mike-goodwin/owasp-threat-dragon

View on GitHub
Star
td/public/app/threatmodels/webreport.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function webreport has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function webreport($timeout, $routeParams, common, datacontext, threatmodellocator) {
    // Using 'Controller As' syntax, so we assign this to the vm variable (for viewmodel).
    /*jshint validthis: true */
    var vm = this;
    var controllerId = 'webreport';
Severity: Minor
Found in td/public/app/threatmodels/webreport.js - About 1 hr to fix

    Function webreport has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function webreport($timeout, $routeParams, common, datacontext, threatmodellocator) {
    Severity: Minor
    Found in td/public/app/threatmodels/webreport.js - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          function activate() {
        common.activateController([getThreatModel()], controllerId)
            .then(function () { log('Activated Web Report Controller'); });
    }
      Severity: Minor
      Found in td/public/app/threatmodels/webreport.js and 1 other location - About 30 mins to fix
      td/public/app/threatmodels/github.js on lines 22..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status