Sign upLogin

mike-north/ember-creditcard

View on GitHub
Star

Showing 2 of 2 total issues

Function ccNumberToType has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function ccNumberToType(params, hash) {
  let [num] = params;
  let result = null;
  switch (true) {
    case /^3[47]/.test(num):
Severity: Major
Found in addon/utils/number-to-type.js - About 2 hrs to fix

    Function luhnChk has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const luhnChk = (function(arr) {
  return function(ccNum) {
    let bit = 1;
    let sum = 0;
    let len = ccNum.length;
    Severity: Minor
    Found in addon/utils/luhn.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language