Sign upLogin

mike-north/ember-perf

View on GitHub
Star

Showing 4 of 10 total issues

Function transitionLogger has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  transitionLogger: on('transitionComplete', function(data) {
    if (this.get('debugMode')) {
      console.group(`Top-Level Transition to ${data.destRoute} (${data.destURL}): ${data.elapsedTime}ms`);
      for (let i = 0; i < data.routes.length; i++) {
        console.group(`${data.routes[i].name} ${data.routes[i].elapsedTime}ms`);
Severity: Minor
Found in addon/services/ember-perf.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doPublish has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function doPublish() {
  console.log('Publishing standard package');
  return publish()
    .then(function() {
      console.log('setting up legacy environment');
Severity: Minor
Found in lib/do-publish.js - About 1 hr to fix

    Function _measureTransition has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _measureTransition(transitionInfo) {
    if (transitionInfo.promise._emberPerfTransitionId) {
      return;
    }
    transitionInfo.promise._emberPerfTransitionId = transitionCounter++;
    Severity: Minor
    Found in addon/services/ember-perf.js - About 1 hr to fix

      Function _measureTransition has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        _measureTransition(transitionInfo) {
    if (transitionInfo.promise._emberPerfTransitionId) {
      return;
    }
    transitionInfo.promise._emberPerfTransitionId = transitionCounter++;
      Severity: Minor
      Found in addon/services/ember-perf.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language