Sign upLogin

milojs/milo-core

View on GitHub
Star
lib/model/connector.js

Summary

Maintainability
F
4 days
Test Coverage

Function Connector$turnOn has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
Open

function Connector$turnOn() {
    if (this.isOn)
        return logger.warn('data sources are already connected');

    var subscriptionPath = this._subscriptionPath =
Severity: Minor
Found in lib/model/connector.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Connector$turnOn has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function Connector$turnOn() {
    if (this.isOn)
        return logger.warn('data sources are already connected');

    var subscriptionPath = this._subscriptionPath =
Severity: Major
Found in lib/model/connector.js - About 4 hrs to fix

    Function linkDataSource has 104 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function linkDataSource(reverseLink, fromDS, toDS, changesQueue, pathTranslation, patternTranslation, dataTranslation, dataValidation) {
        fromDS.onSync('datachanges', onData);
        return onData;

        function onData(message, batch) {
    Severity: Major
    Found in lib/model/connector.js - About 4 hrs to fix

      Function onData has 100 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function onData(message, batch) {
            var sendData = {
                changes: [],
                transaction: batch.transaction
            }
      Severity: Major
      Found in lib/model/connector.js - About 4 hrs to fix

        File connector.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        'use strict';

var Messenger = require('../messenger')
    , pathUtils = require('./path_utils')
    , _ = require('protojs')
        Severity: Minor
        Found in lib/model/connector.js - About 2 hrs to fix

          Function Connector has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function Connector(ds1, mode, ds2, options) {
    setupMode.call(this, mode);

    _.extend(this, {
        ds1: ds1,
          Severity: Minor
          Found in lib/model/connector.js - About 1 hr to fix

            Function Connector has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            function Connector(ds1, mode, ds2, options) {
    setupMode.call(this, mode);

    _.extend(this, {
        ds1: ds1,
            Severity: Minor
            Found in lib/model/connector.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function linkDataSource has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function linkDataSource(reverseLink, fromDS, toDS, changesQueue, pathTranslation, patternTranslation, dataTranslation, dataValidation) {
            Severity: Major
            Found in lib/model/connector.js - About 1 hr to fix

              Avoid too many return statements within this function.
              Open

                              return translatedPath || sourcePath;
              Severity: Major
              Found in lib/model/connector.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (this.depth1)
        this._link1 = linkDataSource('_link2', this.ds2, this.ds1, this._changesQueue1, this.pathTranslation1, this.patternTranslation1, this.dataTranslation1, this.dataValidation1);
                Severity: Major
                Found in lib/model/connector.js and 1 other location - About 1 hr to fix
                lib/model/connector.js on lines 229..230

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (this.depth2)
        this._link2 = linkDataSource('_link1', this.ds1, this.ds2, this._changesQueue2, this.pathTranslation2, this.patternTranslation2, this.dataTranslation2, this.dataValidation2);
                Severity: Major
                Found in lib/model/connector.js and 1 other location - About 1 hr to fix
                lib/model/connector.js on lines 227..228

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status