Sign upLogin

ministryofjustice/govuk_elements_form_builder

View on GitHub
Star

Showing 3 of 8 total issues

Class FormBuilder has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

  class FormBuilder < ActionView::Helpers::FormBuilder

    ActionView::Base.field_error_proc = Proc.new do |html_tag, instance|
      add_error_to_html_tag! html_tag, instance
    end
Severity: Minor
Found in lib/govuk_elements_form_builder/form_builder.rb - About 4 hrs to fix

    Method collection_select has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def collection_select method, collection, value_method, text_method, options = {}, *args
    Severity: Minor
    Found in lib/govuk_elements_form_builder/form_builder.rb - About 45 mins to fix

      Method child_to_parent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.child_to_parent object, child_to_parents={}, parent_object=nil
    return child_to_parents if object == parent_object
    parent_object ||= object

    attribute_objects(object).each do |child|
      Severity: Minor
      Found in app/helpers/govuk_elements_errors_helper.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language