Sign upLogin

mitre-cyber-academy/ctf-scoreboard

View on GitHub
Star

Showing 2 of 6 total issues

Method calculate_standard_solved_challenge_score has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def calculate_standard_solved_challenge_score
    teams.includes(:achievements).joins(
      "LEFT JOIN LATERAL
          (
            SELECT
Severity: Minor
Found in app/models/division.rb - About 1 hr to fix

    Method leave_team has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def leave_team
    is_current_captain = @team.team_captain&.id.eql?(params[:user_id].to_i)

    # Uses count to query database and get the most accurate count so user can't make a team empty
    if is_current_captain && @team.users.count > 1
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language