Sign upLogin

mjackson/mach

View on GitHub
Star
modules/middleware/__tests__/mapper-test.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      describe('that was specified with a custom port', function () {
        it('passes the request through to the mapping', function () {
          return callApp(app, 'http://example.net/three/messages').then(function (conn) {
            expect(conn.status).toEqual(200);
            expect(conn.response.headers['Basename']).toEqual('/three');
Severity: Major
Found in modules/middleware/__tests__/mapper-test.js and 3 other locations - About 4 hrs to fix
modules/middleware/__tests__/mapper-test.js on lines 43..51
modules/middleware/__tests__/mapper-test.js on lines 62..70
modules/middleware/__tests__/mapper-test.js on lines 83..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      describe('and the request is on a different port', function () {
        it('passes the request through to the mapping', function () {
          return callApp(app, 'http://example.org:5000/two/messages').then(function (conn) {
            expect(conn.status).toEqual(200);
            expect(conn.response.headers['Basename']).toEqual('/two');
Severity: Major
Found in modules/middleware/__tests__/mapper-test.js and 3 other locations - About 4 hrs to fix
modules/middleware/__tests__/mapper-test.js on lines 43..51
modules/middleware/__tests__/mapper-test.js on lines 72..80
modules/middleware/__tests__/mapper-test.js on lines 83..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    describe('and there is no remaining path', function () {
      it('passes the request through to the mapping', function () {
        return callApp(app, '/one').then(function (conn) {
          expect(conn.status).toEqual(200);
          expect(conn.response.headers['Basename']).toEqual('/one');
Severity: Major
Found in modules/middleware/__tests__/mapper-test.js and 3 other locations - About 4 hrs to fix
modules/middleware/__tests__/mapper-test.js on lines 43..51
modules/middleware/__tests__/mapper-test.js on lines 62..70
modules/middleware/__tests__/mapper-test.js on lines 72..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    describe('and the mapping has no host', function () {
      it('passes the request through to the mapping', function () {
        return callApp(app, '/one/messages').then(function (conn) {
          expect(conn.status).toEqual(200);
          expect(conn.response.headers['Basename']).toEqual('/one');
Severity: Major
Found in modules/middleware/__tests__/mapper-test.js and 3 other locations - About 4 hrs to fix
modules/middleware/__tests__/mapper-test.js on lines 62..70
modules/middleware/__tests__/mapper-test.js on lines 72..80
modules/middleware/__tests__/mapper-test.js on lines 83..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  describe('when the request does not match a mapping', function () {
    it('passes the request through to the default app', function () {
      return callApp(app, '/three').then(function (conn) {
        expect(conn.status).toEqual(404);
      });
Severity: Major
Found in modules/middleware/__tests__/mapper-test.js and 4 other locations - About 1 hr to fix
modules/middleware/__tests__/file-test.js on lines 35..41
modules/middleware/__tests__/file-test.js on lines 43..49
modules/middleware/__tests__/mapper-test.js on lines 35..41
modules/middleware/__tests__/router-test.js on lines 24..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    describe('and the mapping has a different host', function () {
      it('passes the request through to the default app', function () {
        return callApp(app, 'http://example.com/two').then(function (conn) {
          expect(conn.status).toEqual(404);
        });
Severity: Major
Found in modules/middleware/__tests__/mapper-test.js and 4 other locations - About 1 hr to fix
modules/middleware/__tests__/file-test.js on lines 35..41
modules/middleware/__tests__/file-test.js on lines 43..49
modules/middleware/__tests__/mapper-test.js on lines 26..32
modules/middleware/__tests__/router-test.js on lines 24..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status