mjackson/mach

View on GitHub
modules/utils/sendRequest-browser.js

Summary

Maintainability
D
2 days
Test Coverage

Function sendRequest has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function sendRequest(conn, location) {
  return new AbortablePromise(function (resolve, reject, onAbort) {
    var xhr = new XMLHttpRequest;
    xhr.open(conn.method, location.href, true);

Severity: Major
Found in modules/utils/sendRequest-browser.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        xhr.onreadystatechange = function () {
          if (xhr.error)
            return; // readystatechange triggers before error.
    
          if (xhr.readyState === 2 && READ_HEADERS_RECEIVED_STATE) {
    Severity: Major
    Found in modules/utils/sendRequest-browser.js and 1 other location - About 7 hrs to fix
    lib/umd/mach.js on lines 2056..2077

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 176.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    function pipeContent(xhr, stream, offset) {
      var content = getContent(xhr);
    
      if (content != null) {
        if (content.toString().match(/ArrayBuffer/)) {
    Severity: Major
    Found in modules/utils/sendRequest-browser.js and 1 other location - About 4 hrs to fix
    lib/umd/mach.js on lines 1999..2015

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function enableBinaryContent(xhr) {
      if ('responseType' in xhr) {
        xhr.responseType = 'arraybuffer'; // XHR2
      } else if ('overrideMimeType' in xhr) {
        xhr.overrideMimeType('text/plain; charset=x-user-defined'); // XHR
    Severity: Major
    Found in modules/utils/sendRequest-browser.js and 1 other location - About 2 hrs to fix
    lib/umd/mach.js on lines 2017..2025

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    function copyStatusAndHeaders(xhr, conn) {
      conn.response.headers = xhr.getAllResponseHeaders();
      conn.status = xhr.status;
      return conn.status;
    }
    Severity: Minor
    Found in modules/utils/sendRequest-browser.js and 1 other location - About 55 mins to fix
    lib/umd/mach.js on lines 1979..1983

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status