mluukkai/labtool

View on GitHub
app/assets/javascripts/checklist-editor.js

Summary

Maintainability
D
2 days
Test Coverage

Function activateTable has 164 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function activateTable() {
    var table = $(this);
    var container = table.parents('.topicContainer');
    var topic_id = table.attr('id').replace('topic_','');
    var min_text = table.find('.min');
Severity: Major
Found in app/assets/javascripts/checklist-editor.js - About 6 hrs to fix

    Function calc has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function calc() {
          var min = 0;
          var max = 0;
          for(var i=0; i<cells1.length; i++) {
            var val1 = parseFloat(cells1[i].value,10);
    Severity: Minor
    Found in app/assets/javascripts/checklist-editor.js - About 1 hr to fix

      Function activateRows has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function activateRows() {
            table.find('tr:not(.activated)').each(function() {
              var row = $(this);
              row.addClass("activated");
              row.find('.nametext').click(function() {
      Severity: Minor
      Found in app/assets/javascripts/checklist-editor.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                row.find('.deleteCheck').click(function() {
                  var id = row.find('.link_id').val();
        
                  if (id != "new") {
                    var deleteInput = $('<input type="hidden" name="deleted_topics_checks[]" />');
        Severity: Major
        Found in app/assets/javascripts/checklist-editor.js and 1 other location - About 4 hrs to fix
        app/assets/javascripts/checklist-editor.js on lines 132..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            container.find('.deleteTopic').click(function() {
              var id = container.find('.topic_id').val();
        
              if (id != "new") {
                var deleteInput = $('<input type="hidden" name="deleted_topics[]" />');
        Severity: Major
        Found in app/assets/javascripts/checklist-editor.js and 1 other location - About 4 hrs to fix
        app/assets/javascripts/checklist-editor.js on lines 222..233

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status